Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE changes to show recurring donations for QF #4222

Open
divine-comedian opened this issue May 30, 2024 · 15 comments
Open

FE changes to show recurring donations for QF #4222

divine-comedian opened this issue May 30, 2024 · 15 comments
Labels
QF Quadratic Funding Related

Comments

@divine-comedian
Copy link
Contributor

divine-comedian commented May 30, 2024

Some FE changes should be made that show this recurring donation be in a QF round
like in donate page and donation success page

image.png

image.png

Originally posted by @maryjaf in #3284 (comment)

On the donate page for recurring donations - if the project is in a QF round and optimism is an eligible network for the current QF round we should show the QF related project card on the side instead of the regular card.

On the success page we should show the section related to QF matching on this view as well.

@maryjaf
Copy link
Collaborator

maryjaf commented Jun 11, 2024

  • It would be good if we consider this scenario

  • The project hasn't any one time donation in a round

  • The project has a recurring donation and it be counted in estimated matching

  • The project card is shown like below pic, amount raised in this round is 0 , estimated matching is more than zero (because of recurring donation in the round)

image

cc: @divine-comedian @MohammadPCh

@divine-comedian
Copy link
Contributor Author

nice catch MJ! So the value of the recurring donation is not being considered in the "amount raised this round" field on the project card when the project is inside of an active QF round.

We should count the value of eligible recurring donations made inside the QF round to the given project and include it in this number.

@MohammadPCh I can make a new issue if you prefer or track it here

@MohammadPCh
Copy link
Collaborator

@divine-comedian Yes, please create a new issue :D

@divine-comedian
Copy link
Contributor Author

divine-comedian commented Jun 17, 2024

@maryjaf I created a new issue for the scenario you reported - #4287

Can you confirm if the original parts of this issue are completed?

@maryjaf
Copy link
Collaborator

maryjaf commented Jun 18, 2024

like in donate page and donation success page

Donate page:

  • 1- There is difference between one time and recurring tab for project in a round, please take a look @MohammadPCh
Screen.Recording.2024-06-18.at.10.24.40.AM.mov
  • 2- Estimated matching isn't shown in recurring donation tab
Screen.Recording.2024-06-18.at.10.27.35.AM.mov

Donation success page:

There is no problem in donation success page
image

@divine-comedian
Copy link
Contributor Author

I don't think we defined how to get the estimated matching for a recurring donation...

My guess to do the estimated matching we would need to know

  1. How many seconds are left in the QF round
  2. How much the user is proposing to donate per second

Then we would need to take the seconds left in QF round, multiplied by amount to donate per second, this would become the value we use for the estimated matching.

@maryjaf
Copy link
Collaborator

maryjaf commented Jun 20, 2024

I don't think we defined how to get the estimated matching for a recurring donation...

My guess to do the estimated matching we would need to know

  1. How many seconds are left in the QF round
  2. How much the user is proposing to donate per second

Then we would need to take the seconds left in QF round, multiplied by amount to donate per second, this would become the value we use for the estimated matching

I don't get it correctly , so this behavior is expected or it should be changed

  • 1- There is difference between one time and recurring tab for project in a round, please take a look @MohammadPCh
  • 2- Estimated matching isn't shown in recurring donation tab

@divine-comedian
Copy link
Contributor Author

Oh, the 1st issue looks to be a bigger issue, not related to this issue - I would consider it out of scope here and we can follow it up elsewhere and see how Lauren wants to handle it.

The second issue however - looks like the QF project card hasn't been implemented for recurring donations yet.

@MohammadPCh
Copy link
Collaborator

@divine-comedian can we close this issue? or wrap up the remaining tasks?

@divine-comedian
Copy link
Contributor Author

@divine-comedian can we close this issue? or wrap up the remaining tasks?

Did you resolve the second issue MJ reported? The QF version of the project card should show up when user selects to make a recurring donation from donate page

@divine-comedian divine-comedian added QF Quadratic Funding Related and removed QA labels Jul 8, 2024
@MohammadPCh
Copy link
Collaborator

@lovelgeorge99, could you take care of this and resolve this old issue? Thanks!

@lovelgeorge99
Copy link
Collaborator

For this one i am waiting for a PR in imapct graph to get reviewd which gets the recurring dontaions from a data range.

@lovelgeorge99, could you take care of this and resolve this old issue? Thanks!

@divine-comedian
Copy link
Contributor Author

@lovelgeorge99 what is the update on this issue?

@lovelgeorge99
Copy link
Collaborator

@divine-comedian this issuse was resolved here
#3284

@divine-comedian
Copy link
Contributor Author

Looks like MJs reported issue is done - moving this issue over to done.

image

@divine-comedian divine-comedian removed the P2 A normal to do item or feature. label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QF Quadratic Funding Related
Projects
Status: Done
Development

No branches or pull requests

4 participants