-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE changes to show recurring donations for QF #4222
Comments
|
nice catch MJ! So the value of the recurring donation is not being considered in the "amount raised this round" field on the project card when the project is inside of an active QF round. We should count the value of eligible recurring donations made inside the QF round to the given project and include it in this number. @MohammadPCh I can make a new issue if you prefer or track it here |
@divine-comedian Yes, please create a new issue :D |
Donate page:
Screen.Recording.2024-06-18.at.10.24.40.AM.mov
Screen.Recording.2024-06-18.at.10.27.35.AM.movDonation success page: |
I don't think we defined how to get the estimated matching for a recurring donation... My guess to do the estimated matching we would need to know
Then we would need to take the seconds left in QF round, multiplied by amount to donate per second, this would become the value we use for the estimated matching. |
I don't get it correctly , so this behavior is expected or it should be changed
|
Oh, the 1st issue looks to be a bigger issue, not related to this issue - I would consider it out of scope here and we can follow it up elsewhere and see how Lauren wants to handle it. The second issue however - looks like the QF project card hasn't been implemented for recurring donations yet. |
@divine-comedian can we close this issue? or wrap up the remaining tasks? |
Did you resolve the second issue MJ reported? The QF version of the project card should show up when user selects to make a recurring donation from donate page |
@lovelgeorge99, could you take care of this and resolve this old issue? Thanks! |
For this one i am waiting for a PR in imapct graph to get reviewd which gets the recurring dontaions from a data range.
|
@lovelgeorge99 what is the update on this issue? |
@divine-comedian this issuse was resolved here |
Some FE changes should be made that show this recurring donation be in a QF round
like in donate page and donation success page
Originally posted by @maryjaf in #3284 (comment)
On the donate page for recurring donations - if the project is in a QF round and optimism is an eligible network for the current QF round we should show the QF related project card on the side instead of the regular card.
On the success page we should show the section related to QF matching on this view as well.
The text was updated successfully, but these errors were encountered: