Include Recurring donation number on QF project card

[divine-comedian]

It would be good if we consider this scenario

• The project hasn't any one time donation in a round
• The project has a recurring donation and it be counted in estimated matching
• The project card is shown like below pic, amount raised in this round is 0 , estimated matching is more than zero (because of recurring donation in the round)

So the value of the recurring donation is not being considered in the "amount raised this round" field on the project card when the project is inside of an active QF round.

We should count the value of eligible recurring donations made inside the QF round to the given project and include it in this number.

Originally posted by @maryjaf in #4222 (comment)

FYI @koday1

[MohammadPCh]

@lovelgeorge99 can you take it, please? Thanks

[maryjaf]

When I change the start time of round , the sum of recurring donation in the round should be changed, am I right?

• the start date of round was 19/06
• the raised amount in the round was 129.63
• I changed the start time into 10/08
• but raised amount hasn't been changed and it is shown 129.63

https://staging.giveth.io/project/testtttttttt?tab=donations

and also the Number of contributor should be set based on both one time and recurring donation
for example for above project it should be set 2 contributors

[maryjaf]

and one more thing this issue hasn't been tested but I think since this change was on stagimg it was deployed on prod by the previous release, am I right?

unfortunately I hadn't seen this in QA board yesterday

[lovelgeorge99]

@maryjaf the current changes that I made , should reflect the change of amount in the project card . I have not made the changes to reflect it on the project donation section ..will work on that next. Thanks for the feedback

[maryjaf]

When I change the start time of round , the sum of recurring donation in the round should be changed, am I right?

• the start date of round was 19/06
• the raised amount in the round was 129.63
• I changed the start time into 10/08
• but raised amount hasn't been changed and it is shown 129.63

https://staging.giveth.io/project/testtttttttt?tab=donations

and also the Number of contributor should be set based on both one time and recurring donation for example for above project it should be set 2 contributors

In this scenario, the project card is shown like below pic

it seems the number of amount raised in the round and estimated matching isn't correct

[maryjaf]

and one more thing this issue hasn't been tested but I think since this change was on stagimg it was deployed on prod by the previous release, am I right?

unfortunately I hadn't seen this in QA board yesterday

Since this issue hadn't been tested, Can we revert this change on prod ?

[lovelgeorge99]

and one more thing this issue hasn't been tested but I think since this change was on stagimg it was deployed on prod by the previous release, am I right?
unfortunately I hadn't seen this in QA board yesterday

Since this issue hadn't been tested, Can we revert this change on prod ?

Yes,this should be reverted

[maryjaf]

and one more thing this issue hasn't been tested but I think since this change was on stagimg it was deployed on prod by the previous release, am I right?
unfortunately I hadn't seen this in QA board yesterday

Since this issue hadn't been tested, Can we revert this change on prod ?

Yes,this should be reverted

who should do that ?
@lovelgeorge99
cc: @MohammadPCh @divine-comedian

[MohammadPCh]

@maryjaf @lovelgeorge99 Could we explore fixing it rather than reverting?

[MohammadPCh]

@maryjaf @lovelgeorge99 I'll remove the recurring donation amount from the card and release a hotfix. Please follow up on this issue to ensure it's fully resolved. Thanks!

[lovelgeorge99]

@maryjaf i have added the sum of recurring donations and the number of donars made in QF round

also should that amount also be included here?

[maryjaf]

When I change the start time of round , the sum of recurring donation in the round should be changed, am I right?

• the start date of round was 19/06
• the raised amount in the round was 129.63
• I changed the start time into 10/08
• but raised amount hasn't been changed and it is shown 129.63

https://staging.giveth.io/project/testtttttttt?tab=donations

and also the Number of contributor should be set based on both one time and recurring donation for example for above project it should be set 2 contributors

Have you seen this scenario ? @lovelgeorge99

[mohammadranjbarz]

When I change the start time of round , the sum of recurring donation in the round should be changed, am I right?

• the start date of round was 19/06
• the raised amount in the round was 129.63
• I changed the start time into 10/08
• but raised amount hasn't been changed and it is shown 129.63

https://staging.giveth.io/project/testtttttttt?tab=donations

and also the Number of contributor should be set based on both one time and recurring donation for example for above project it should be set 2 contributors

We connect the qfRound and recurring donation streams when donations are made, so changing the start time of the qfRound later would not affect it and can't change the relation between donations and qfRounds

[lovelgeorge99]

@mohammadranjbarz this is the recurring donations in that qf round and this should be shown in the QF project card...right?

[mohammadranjbarz]

@mohammadranjbarz this is the recurring donations in that qf round and this should be shown in the QF project card...right?

@lovelgeorge99 Yeah I think so

[lovelgeorge99]

https://staging.giveth.io/project/testing-project-lovel-george

@maryjaf This project does not have any one time donation only recurring donations and it is shown in the QF project card>
Can you check and verify

[maryjaf]

https://staging.giveth.io/project/testing-project-lovel-george

Yeah we can call it Done