Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stellar | changes on Donation page #4422

Closed
7 tasks done
MoeNick opened this issue Jul 17, 2024 · 33 comments
Closed
7 tasks done

Stellar | changes on Donation page #4422

MoeNick opened this issue Jul 17, 2024 · 33 comments
Assignees
Labels

Comments

@MoeNick
Copy link
Member

MoeNick commented Jul 17, 2024

Design Resources: https://www.figma.com/design/5qh6OaJRJSCNj2h22MMSwa/Stellar-Grant?node-id=8135-39281&t=9OPb4ZVdDbPcyjdV-4

For logged in users:

  • We show a toast message for the projects which has the Stellar address defined. Copy should be Try Donating on Stellar
    image

  • When the user clicks on the toast msg, we show another screen. In this screen there's only one token selected, we remove the Donate to Giveth and the button will change to next. In this screen user only out the amount, we show the USD price there as well.

image

  • We should create a draft/pending donation and show the QR screen.

image.png

  • Once we detect the trn on the chain we show success page.

image.png

  • if the timer set to 0, and we could not detect the trn, we show the failed donation screen. In this case we make the transaction failed.

image.png

  • user can ask for a new QR code when the time is up, in this case, we should create a new pending/donation.

image.png

  • user can ask for a new QR code, during the valid time by pressing the back icon, in this case, we should delete the pending trn and redirect user to the last screen while the same token is selected.

image.png

For not-logged in users:
The flow would be the same.

@MoeNick
Copy link
Member Author

MoeNick commented Jul 30, 2024

@Meriem-BM I updated the issue based on recent UI changes.

@maryjaf
Copy link
Collaborator

maryjaf commented Aug 13, 2024

[ ] We should create a draft/pending donation and show the QR screen.

  • 1- The QR code is shown loading for me , could you please take a look @Meriem-BM

image

update: it isn't a permanent problem

@maryjaf
Copy link
Collaborator

maryjaf commented Aug 13, 2024

  • When the user clicks on the toast msg, we show another screen. In this screen there's only one token selected, we remove the Donate to Giveth and the button will change to next. In this screen user only out the amount, we show the USD price there as well.
  • 2-
    in this page the name of project should be shown for example in below pic the name of project is "Test stellar", but "Community of makers" is shown

image

@Meriem-BM
Copy link
Collaborator

Meriem-BM commented Aug 13, 2024

in this page the name of project should be shown for example in below pic the name of project is "Test stellar", but "Community of makers" is shown

@MoeNick is that right? as I saw in the design "The Community of Makers"

@maryjaf
Copy link
Collaborator

maryjaf commented Aug 13, 2024

  • 3-
  • project recipient address is GBNR3UMCYZGYUT5RZS5P32LJLWEMJL3PXHQZJN2QQTR5V4SHLXP7MFI6 and it is activate
  • I scan the QR code like as below screen record
  • but finally I couldn't complete the donation and it remains loading on my device

image

I couldn't find out what is the problem , could you please take a look? @MoeNick @Meriem-BM

RPReplay_Final1723545558.mp4
RPReplay_Final1723545617.mp4

@Meriem-BM
Copy link
Collaborator

I couldn't find out what is the problem , could you please take a look? @MoeNick @Meriem-BM

I actually tested with LOBSTR, Exodus is not supported in my country

@Meriem-BM
Copy link
Collaborator

Meriem-BM commented Aug 13, 2024

Seems like the information aren't filled correctly to address and from address

@MoeNick
Copy link
Member Author

MoeNick commented Aug 13, 2024

Try donation several time with different wallets, the failure rate on that chain is high. @maryjaf

@MoeNick
Copy link
Member Author

MoeNick commented Aug 13, 2024

in this page the name of project should be shown for example in below pic the name of project is "Test stellar", but "Community of makers" is shown

@MoeNick is that right? as I saw in the design "The Community of Makers"

No @Meriem-BM it should be the name of project.

@maryjaf
Copy link
Collaborator

maryjaf commented Aug 13, 2024

Seems like the information aren't filled correctly to address and from address

Yeah , from address is correct
But “to”’ it seems isn’t correct
I’ve tested with XLM wallet

@maryjaf
Copy link
Collaborator

maryjaf commented Aug 13, 2024

[ ] user can ask for a new QR code, during the valid time by pressing the back icon, in this case, we should delete the pending trn and redirect user to the last screen while the same token is selected.

  • 4-
    If during the valid time, user taps on back icon , in new trn the timer isn't shown correctly
Screen.Recording.2024-08-13.at.3.22.45.PM.mov

@MoeNick
Copy link
Member Author

MoeNick commented Aug 13, 2024

@Meriem-BM
it's not like design, fonts and copies.
image

UPDATE:
DONE

@MoeNick
Copy link
Member Author

MoeNick commented Aug 13, 2024

@Meriem-BM
image

I scanned the QR in Exodus, but it is showing ‘pay’ in the address rather than the address.

@MoeNick
Copy link
Member Author

MoeNick commented Aug 13, 2024

@Meriem-BM
I donated successfully to the MJ project with Lovstr. App count down is blinking and seems it did not detect my donation.

https://lobstr.co/explore/0239636bb0ed0a719dc95c3adfacdfe7071c1a5c631521b80c3008532b71aeda

https://www.loom.com/share/4d648d3a5cdf47959bfc2a6adaec742d?sid=f7b6beec-3b11-4782-8c32-d6028ba546d5

@MoeNick
Copy link
Member Author

MoeNick commented Aug 13, 2024

@Meriem-BM
when the QR expires, the view is not like the design.

image

We should have blue toast message on QR code, and we should have a Update QR code section right button of the project
image

@Meriem-BM
Copy link
Collaborator

@Meriem-BM when the QR expires, the view is not like the design.

image

We should have blue toast message on QR code, and we should have a Update QR code section right button of the project image

Yes, it's implemented I think that was a bug, will push a fix and see.

@Meriem-BM
Copy link
Collaborator

@Meriem-BM I donated successfully to the MJ project with Lovstr. App count down is blinking and seems it did not detect my donation.

https://lobstr.co/explore/0239636bb0ed0a719dc95c3adfacdfe7071c1a5c631521b80c3008532b71aeda

https://www.loom.com/share/4d648d3a5cdf47959bfc2a6adaec742d?sid=f7b6beec-3b11-4782-8c32-d6028ba546d5

You will need to wait about 5 mins from the time you made that donation, every 5 mins we pull updated data from Backend, that's how it's implemented, I think we should add some info toast to inform the user to wait 5 mins.
Also you can check the receipt page and refresh to check your donation status.

@Meriem-BM
Copy link
Collaborator

Meriem-BM commented Aug 14, 2024

@Meriem-BM image

I scanned the QR in Exodus, but it is showing ‘pay’ in the address rather than the address.

Seems we have a problem with the QR code we generate, it does not fill correct fields for all wallets, we need to find how to generate a QR code supported by all wallets.

update: will push the fix for this too

@Meriem-BM
Copy link
Collaborator

Meriem-BM commented Aug 14, 2024

[ ] We should create a draft/pending donation and show the QR screen.

  • 1- The QR code is shown loading for me , could you please take a look @Meriem-BM

image

update: it isn't a permanent problem

I don't know how It happened, does that project has a memo, I tested with no memo, for now I changed to showing an error toast if QR code generation failed.

Screenshot 2024-08-14 at 07 51 10 (2)

UPDATE:
DONE

@maryjaf
Copy link
Collaborator

maryjaf commented Aug 14, 2024

  • 5-

Is this the correct design when the wallet isn't connected? @MoeNick
I haven't found the design for this condition https://www.figma.com/design/5qh6OaJRJSCNj2h22MMSwa/Stellar-Grant?node-id=8135-39452&t=Z2wq3KnSSYXn2wRD-0

image

@MoeNick
Copy link
Member Author

MoeNick commented Aug 14, 2024

No 5 @maryjaf is like what we have in issue, the same design with connected.
image

@maryjaf
Copy link
Collaborator

maryjaf commented Aug 14, 2024

  • 3-
  • project recipient address is GBNR3UMCYZGYUT5RZS5P32LJLWEMJL3PXHQZJN2QQTR5V4SHLXP7MFI6 and it is activate
  • I scan the QR code like as below screen record
  • but finally I couldn't complete the donation and it remains loading on my device

I see some change related to "To Address" field after last PR, but it hasn't been fixed yet @Meriem-BM
maybe it's related to showing this "Stellar:" in "To Address" field

image
image
image

@maryjaf
Copy link
Collaborator

maryjaf commented Aug 14, 2024

@Meriem-BM
when the QR expires, the view is not like the design.

  • 6- The time is over and I see the below pic , there is no button for Update QR code and the donatio status is Waiting

image

@maryjaf
Copy link
Collaborator

maryjaf commented Aug 14, 2024

  • 7- it would be good if this scenario be handled
  • user enters unusual number
Screen.Recording.2024-08-14.at.2.20.49.PM.mov

@maryjaf
Copy link
Collaborator

maryjaf commented Aug 14, 2024

  • Once we detect the trn on the chain we show success page.
image.png
  • 8- Givback eligible should be set on stellar ? I see below pic
    @MoeNick
    image

  • 9- By tapping on "view the transaction" this page is shown
    @Meriem-BM

image

@maryjaf
Copy link
Collaborator

maryjaf commented Aug 14, 2024

@Meriem-BM I donated successfully to the MJ project with Lovstr. App count down is blinking and seems it did not detect my donation.
https://lobstr.co/explore/0239636bb0ed0a719dc95c3adfacdfe7071c1a5c631521b80c3008532b71aeda
https://www.loom.com/share/4d648d3a5cdf47959bfc2a6adaec742d?sid=f7b6beec-3b11-4782-8c32-d6028ba546d5

You will need to wait about 5 mins from the time you made that donation, every 5 mins we pull updated data from Backend, that's how it's implemented, I think we should add some info toast to inform the user to wait 5 mins. Also you can check the receipt page and refresh to check your donation status.

  • 10-
    after about 5 mins, the success page is shown like as below screen record
    could you please take a look on below video to approve this behavior ? @MoeNick
Screen.Recording.2024-08-14.at.4.43.44.PM.mov

@MoeNick
Copy link
Member Author

MoeNick commented Aug 14, 2024

  • 11- Was talking to @Meriem-BM to seek for a live solution to detect in seconds, or we run one manual fetch data before
  • we let the user click back,
  • before changing the status to failed OR when the time is up
  • before raising a ticket.
    So we make sure it's not a pending state on our side and no need to mention the 5 min @maryjaf (FYI)

@MoeNick
Copy link
Member Author

MoeNick commented Aug 15, 2024

For 10, I think it's fine for now. @maryjaf

@maryjaf
Copy link
Collaborator

maryjaf commented Aug 18, 2024

@Meriem-BM
when the QR expires, the view is not like the design.

  • 6- The time is over and I see the below pic , there is no button for Update QR code and the donatio status is Waiting
  • Failed scenario: DONE

I see new behavior related to Item - [ ] 6

  • The time is over, and I see failed status , when I tap on back and set new amount for donation , by tapping on next button the status of previous donation is shown
    @Meriem-BM
Screen.Recording.2024-08-18.at.3.45.13.PM.mov
  • Pending scenario: DONE
  • user can ask for a new QR code, during the valid time by pressing the back icon, in this case, we should delete the pending trn and redirect user to the last screen while the same token is selected.
  • during the valid time by pressing the back icon and then set amount and tap on next, the previous transaction and timer is shown
Screen.Recording.2024-08-18.at.3.58.33.PM.mov

@maryjaf
Copy link
Collaborator

maryjaf commented Aug 20, 2024

  • 9- By tapping on "view the transaction" this page is shown
    @Meriem-BM

This item hasn't been fixed yet

@Meriem-BM
Copy link
Collaborator

Meriem-BM commented Aug 21, 2024

  • 9- By tapping on "view the transaction" this page is shown
    @Meriem-BM

This item hasn't been fixed yet

It's fixed for me, I just tested.

@Meriem-BM
Copy link
Collaborator

  • 7- it would be good if this scenario be handled
  • user enters unusual number

Screen.Recording.2024-08-14.at.2.20.49.PM.mov

WDYT @maryjaf should we add a maximum amount that user should enter? because for other chains it's same

@maryjaf
Copy link
Collaborator

maryjaf commented Sep 3, 2024

Yeah it is same for other chains, I'll create separate issue for that
we can ignore it for now

@maryjaf maryjaf closed this as completed by moving to Merged to Production in All-Devs Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants