-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stellar | Check pending donation onchain on specific events #4573
Comments
FYI: @maryjaf |
@maryjaf this one ready for test. |
Could you please tell me more about this new change and behavior? actually what changes was made in this page? |
@maryjaf user might make a donation in last minutes, or scan QR code and tries to go back which will mark it as failed, and since we refresh UI every 5 mins when user is waiting for status update it might be missed, so we added fetching updated status on certain events (when time is up, when user try raising a ticket, or hen going back) to avoid any mismatch and get last status before those events. |
|
For 2 I think we can do it while loading the page if @Meriem-BM agrees. |
my question is that if the showing pending status in this scenario is correct when the the time is over and there is no donation? Screen.Recording.2024-08-20.at.11.58.21.AM.mov |
kindly reminder |
For 3 - the status should change to failed when the time is up, A manual check on this event could only change the status to success if there's a donation is detected on-chain within the 5 min intervals. @maryjaf |
Is there an update related to this item? |
@maryjaf the cron job runs every minute to get transactions on stellar, so I make sure to not mark any donation as failed when time is up until one minute passes, to make sure if any donation detected in next minute, because the user might donation in last minute on seconds. if you wait 1 min it will be changed to failed. |
Was talking to @Meriem-BM to seek for a live solution to detect in seconds, or we run one manual fetch data before
So we make sure it's not a pending state on our side and no need to mention the 5 min @maryjaf (FYI)
Originally posted by @MoeNick in #4422 (comment)
The text was updated successfully, but these errors were encountered: