Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: added recurring tab as default for OP address #4623

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

kkatusic
Copy link
Collaborator

@kkatusic kkatusic commented Aug 26, 2024

Summary by CodeRabbit

  • New Features
    • The 'RECURRING' tab is now set as the default active tab in the DonationCard component when the project has an operational address, enhancing user navigation based on project status.

@kkatusic kkatusic requested a review from RamRamez August 26, 2024 13:01
@kkatusic kkatusic self-assigned this Aug 26, 2024
Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giveth-dapps-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 0:27am

Copy link
Contributor

coderabbitai bot commented Aug 26, 2024

Walkthrough

The changes introduce a new useEffect hook in the DonationCard component. This hook checks for the absence of the tab query parameter and the presence of a hasOpAddress flag. If both conditions are met, it sets the active tab to ETabs.RECURRING. This modification ensures that the 'RECURRING' tab is activated by default when specific project conditions are fulfilled.

Changes

Files Change Summary
src/components/views/donate/DonationCard.tsx Added a useEffect hook to set the active tab to ETabs.RECURRING based on URL query parameters and project state.

Poem

🐰 In a world of tabs, so bright and clear,
A new path unfolds, bringing cheer!
With a hop and a skip, the RECURRING's in sight,
Guiding our friends to the right tab tonight.
So let's celebrate this change with glee,
For every donation brings joy, you see! 🎉


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1cb4c02 and 2474052.

Files selected for processing (1)
  • src/components/views/donate/DonationCard.tsx (1 hunks)
Additional comments not posted (1)
src/components/views/donate/DonationCard.tsx (1)

96-100: Update dependency array of useEffect hook.

The useEffect hook should have a dependency on router.query instead of router.query.tab to ensure it runs when any query parameter changes.

Apply this diff to update the dependency array:

- }, [router.query.tab, hasOpAddress]);
+ }, [router.query, hasOpAddress]);

Likely invalid or redundant comment.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (1)
src/components/views/donate/DonationCard.tsx (1)

95-95: Fix typo in comment.

The word "rpoject" should be corrected to "project".

- // This ensures that the 'RECURRING' tab is active by default if rpoject has Op Address.
+ // This ensures that the 'RECURRING' tab is active by default if project has Op Address.

src/components/views/donate/DonationCard.tsx Outdated Show resolved Hide resolved
@divine-comedian
Copy link
Contributor

@MohammadPCh @mateodaza @RamRamez - if we can review this one with a higher priority that would be great! I think this small change will make a big difference in getting people to try out this feature.

Copy link
Collaborator

@Meriem-BM Meriem-BM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kkatusic, LGTM!

@kkatusic kkatusic merged commit 3378d3c into develop Sep 5, 2024
3 checks passed
@kkatusic kkatusic deleted the feat/recurring_donation_default branch September 5, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: QA
Development

Successfully merging this pull request may close these issues.

3 participants