Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy changes for GIVbacks eligiblity #4742

Merged
merged 9 commits into from
Sep 17, 2024

Conversation

divine-comedian
Copy link
Contributor

@divine-comedian divine-comedian commented Sep 16, 2024

changing copy on toasts, forms and components related to changes of decentralized verification v1

Summary by CodeRabbit

  • New Features

    • Enhanced clarity in descriptions for GIVbacks eligibility across multiple languages.
    • Introduced a new GraphQL query for fetching allocated GIVbacks data.
  • Bug Fixes

    • Updated error messages to reflect specific eligibility forms for GIVbacks instead of general project verification.
  • Documentation

    • Improved metadata descriptions for Giveth-related projects, emphasizing GIVbacks eligibility.
  • Style

    • Streamlined UI by removing unused components and updating terminology for consistency.
  • Chores

    • Minor textual updates across various components to clarify project eligibility and donor rewards.

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giveth-dapps-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 2:53pm

Copy link
Contributor

coderabbitai bot commented Sep 16, 2024

Walkthrough

The pull request introduces updates to localization files and various components within the Giveth platform, primarily focusing on clarifying language related to GIVbacks eligibility. Changes include replacing terms like "verified projects" with "GIVbacks eligible projects" across multiple languages and components, enhancing the precision of messaging. Additionally, new GraphQL queries and data-fetching mechanisms are introduced to improve functionality related to GIVback allocations.

Changes

File Path Change Summary
lang/ca.json, lang/en.json, lang/es.json Updated language strings to clarify GIVbacks eligibility, replacing "verified projects" with "GIVbacks eligible projects" across various labels and descriptions.
src/apollo/gql/gqlGivbacks.ts Introduced a new GraphQL query FETCH_ALLOCATED_GIVBACKS to retrieve data related to allocated GIVbacks, enhancing data management capabilities.
src/components/GIVeconomyPages/GIVbacks.tsx Removed unused components and implemented a new data-fetching mechanism for allocated GIVbacks, streamlining the UI and improving dynamic data rendering.
src/components/views/claim/cards/Connect.tsx Updated text from "donate to verified projects" to "donate to GIVbacks eligible projects" for clarity.
src/components/views/claim/cards/Donate.tsx Changed text from "Donate to verified projects" to "Donate to GIVbacks eligible projects" to specify eligibility.
src/components/views/landings/GIVBacks/*.tsx Multiple components updated to replace "verified projects" with "GIVbacks eligible projects," enhancing clarity regarding project selection and donation eligibility.
src/content/metatags.ts Updated metadata descriptions to reflect changes in project eligibility terminology, emphasizing GIVbacks eligibility.
src/context/verification.context.tsx Modified error handling logic to reflect "givbacks eligibility form" instead of "project verification form," improving error message clarity.
src/lib/constants/shareContent.ts Updated messaging in share content to specify projects applying for "GIVbacks eligible" status rather than general verification.

Possibly related PRs

Suggested labels

Code Review

🐇 In the meadow, changes bloom,
GIVbacks now have clearer room.
From verified to eligible, we say,
Helping donors find their way.
With data fetching, the flow is bright,
Hopping forward, all feels right! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@divine-comedian
Copy link
Contributor Author

@mateodaza Do you mind taking a look and merging if it looks good

@mateodaza
Copy link
Member

mateodaza commented Sep 16, 2024

@mateodaza Do you mind taking a look and merging if it looks good

It looks good, just wondering if those copies won't require translation for spanish and catalan? or that for later

@divine-comedian
Copy link
Contributor Author

@mateodaza Do you mind taking a look and merging if it looks good

It looks good, just wondering if those copies won't require translation for spanish and catalan? or that for later

I'd like to get feedback on the english copy then I should make the final changes to spanish and catalan versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA
Development

Successfully merging this pull request may close these issues.

3 participants