Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/arbitrum #1341

Merged
merged 14 commits into from
Feb 20, 2024
Merged

Feat/arbitrum #1341

merged 14 commits into from
Feb 20, 2024

Conversation

aminlatifi
Copy link
Member

@aminlatifi aminlatifi commented Feb 19, 2024 •
edited
Loading

@aminlatifi aminlatifi marked this pull request as draft February 19, 2024 06:31
@aminlatifi aminlatifi marked this pull request as ready for review February 19, 2024 14:45
CarlosQ96
CarlosQ96 approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@CarlosQ96 CarlosQ96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Amin thanks!

mohammadranjbarz
mohammadranjbarz requested changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@mohammadranjbarz mohammadranjbarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aminlatifi
It seems good to me, but there are some things that should add Arbitrum networkId there:

  1. qfRoundTab.ts
  2. tokenTab.ts

src/services/chains/index.test.ts Outdated Show resolved Hide resolved
@aminlatifi
Copy link
Member Author

Thanks @aminlatifi It seems good to me, but there are some things that should add Arbitrum networkId there:

  1. qfRoundTab.ts
  2. tokenTab.ts

I had added already at some points, which part do you mean?

@aminlatifi aminlatifi merged commit ea652a5 into staging Feb 20, 2024
3 checks passed
@aminlatifi aminlatifi deleted the feat/arbitrum branch February 20, 2024 10:20
mohammadranjbarz added a commit that referenced this pull request Feb 25, 2024
@mohammadranjbarz @RamRamez
@jainkrati @aminlatifi
v1.23.2 2024-02-25 Ortto, Arbitrum (#1342)
1724067 
* Write test cases for recurringDonationsByUserId

* Add recurringDonationsByUserId codes

* Write test cases for updateRecurringDonationStatus

* add updateOrttoUser

* remove Segment

* add update user using Ortto

* revert cors

* prevent updating Ortto user on staging

* Remove start date for fetch users and rounds needing passport score

* Fix query on addNewUserPassportScoreWithGitcoinData

* Fix query on findPassportScoreByUserIdAndQfRoundId

* Change type of passportScore from integer to float with migration

* Fix userPassportScore test cases

* 1.23.2

* add updateOrttoUser to syncDonationStatusWithBlockchainNetwork

* add updateOrttoUser to importLostDonations

* add getUserDonationStats

* rename sendSegmentEventForDonation

* add donation fields to updateOrttoUser

* add donation fields to updateOrttoUser req

* Feat/arbitrum (#1341)

* Added arbitrum secret keys

* Added arbitrum seed tokens

* Fixed test issue

* Added acceptFunOnArbitrumFilter

* Removed .only attribute from a test had remained by mistake

* Added token verification tests

* Updated validators to support arbitrum

* Fixed coingecko id of TrueUsd

* Changed a test description

* rebuild

* Add userId to all notification center calls

* fix Ortto totalDonated decimal points

* turn of Ortto calls on staging

* change ortto merge strategy on staging

* fix env var name

* Fixed pinata image upload issue (#1350)

Giveth/giveth-dapps-v2#3779

Co-authored-by: Krati Jain <kratijain88@gmail.com>

* Made tests compatible with new pinFile output format

* fix assigning user in donationReceived

* add email address of project owner to donationReceived

* Return qfRounds in projectByUserId response

Giveth/giveth-dapps-v2#3283 (comment)

* Add recurringDonationTab in admin panel to fix donation page (#1355)

related #1353

* remove .only from projectsByUserId test case

* Prettify codes

* Remove all things about user_passport_score (#1348)

* Remove all things about user_passport_score

* Bring back user_passport_score migrations

* add qfRound join to findDonationById

* Revert "add qfRound join to findDonationById"

This reverts commit c7695ea.

* Add qfRound join to findDonationById funciton (#1358)

* add Ortto to example.env (#1359)

---------

Co-authored-by: Ramin <raminramazanpour@gmail.com>
Co-authored-by: Krati Jain <kratijain88@gmail.com>
Co-authored-by: Amin Latifi <a.latifi.al@gmail.com>
mohammadranjbarz added a commit that referenced this pull request Feb 27, 2024
@RamRamez @jainkrati
@aminlatifi @mohammadranjbarz
merge Master to staging (#1369)
06f054a 
* Hotfix/image upload (#1351)

* Fixed pinata image upload issue

Giveth/giveth-dapps-v2#3779

* Fixed test issue

* v1.23.2 2024-02-25 Ortto, Arbitrum (#1342)

* Write test cases for recurringDonationsByUserId

* Add recurringDonationsByUserId codes

* Write test cases for updateRecurringDonationStatus

* add updateOrttoUser

* remove Segment

* add update user using Ortto

* revert cors

* prevent updating Ortto user on staging

* Remove start date for fetch users and rounds needing passport score

* Fix query on addNewUserPassportScoreWithGitcoinData

* Fix query on findPassportScoreByUserIdAndQfRoundId

* Change type of passportScore from integer to float with migration

* Fix userPassportScore test cases

* 1.23.2

* add updateOrttoUser to syncDonationStatusWithBlockchainNetwork

* add updateOrttoUser to importLostDonations

* add getUserDonationStats

* rename sendSegmentEventForDonation

* add donation fields to updateOrttoUser

* add donation fields to updateOrttoUser req

* Feat/arbitrum (#1341)

* Added arbitrum secret keys

* Added arbitrum seed tokens

* Fixed test issue

* Added acceptFunOnArbitrumFilter

* Removed .only attribute from a test had remained by mistake

* Added token verification tests

* Updated validators to support arbitrum

* Fixed coingecko id of TrueUsd

* Changed a test description

* rebuild

* Add userId to all notification center calls

* fix Ortto totalDonated decimal points

* turn of Ortto calls on staging

* change ortto merge strategy on staging

* fix env var name

* Fixed pinata image upload issue (#1350)

Giveth/giveth-dapps-v2#3779

Co-authored-by: Krati Jain <kratijain88@gmail.com>

* Made tests compatible with new pinFile output format

* fix assigning user in donationReceived

* add email address of project owner to donationReceived

* Return qfRounds in projectByUserId response

Giveth/giveth-dapps-v2#3283 (comment)

* Add recurringDonationTab in admin panel to fix donation page (#1355)

related #1353

* remove .only from projectsByUserId test case

* Prettify codes

* Remove all things about user_passport_score (#1348)

* Remove all things about user_passport_score

* Bring back user_passport_score migrations

* add qfRound join to findDonationById

* Revert "add qfRound join to findDonationById"

This reverts commit c7695ea.

* Add qfRound join to findDonationById funciton (#1358)

* add Ortto to example.env (#1359)

---------

Co-authored-by: Ramin <raminramazanpour@gmail.com>
Co-authored-by: Krati Jain <kratijain88@gmail.com>
Co-authored-by: Amin Latifi <a.latifi.al@gmail.com>

* call NotificationAdapter in verifyVerificationForms

---------

Co-authored-by: Krati Jain <kratijain88@gmail.com>
Co-authored-by: Amin Latifi <a.latifi.al@gmail.com>
Co-authored-by: mohammadranjbarz <mranjbar.z2993@gmail.com>
@mohammadranjbarz mohammadranjbarz mentioned this pull request May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosQ96 CarlosQ96 CarlosQ96 approved these changes

@jainkrati jainkrati jainkrati approved these changes

@mohammadranjbarz mohammadranjbarz Awaiting requested review from mohammadranjbarz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aminlatifi @jainkrati @mohammadranjbarz @CarlosQ96