Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve array interface of
Raster
for consistency withnp.ma.masked_array
operations #302Improve array interface of
Raster
for consistency withnp.ma.masked_array
operations #302Changes from 14 commits
d90bfa8
147db67
edb967c
befc4a8
a837901
9a150cb
674750f
4984d56
587e571
3a7db58
7ed901c
4d84a72
79e3bf6
0a1b551
a6fb645
3d78d28
189fc4d
8d85d02
2830135
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you define the type of the output (I assume
np.ndarray
) rather than ignoring mypy complain?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type of the output is already defined for
__array_ufunc__
and__array_function__
in the function definition.Mypy still complains about something else specific to those lines, I think it's the indexing of
inputs
or something similar. I couldn't figure it out so I silenced it.