Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report MySt-NB failures as error in Sphinx build #378

Merged
merged 11 commits into from
Aug 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dev-environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ dependencies:
- matplotlib
- pyproj
- rasterio>=1.3
- numpy=1.24
- scipy
- tqdm
- xarray
Expand Down
2 changes: 2 additions & 0 deletions doc/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@

# For myst-nb to find the Jupyter kernel (=environment) to run from
nb_kernel_rgx_aliases = {".*geoutils.*": "python3"}
# To raise a Sphinx build error on notebook failure
nb_execution_raise_on_error = True

intersphinx_mapping = {
"python": ("https://docs.python.org/", None),
Expand Down
1 change: 1 addition & 0 deletions environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ dependencies:
- matplotlib
- pyproj
- rasterio>=1.3
- numpy=1.24
- scipy
- tqdm
- xarray
Expand Down
10 changes: 9 additions & 1 deletion geoutils/vector.py
Original file line number Diff line number Diff line change
Expand Up @@ -590,10 +590,18 @@ def dissolve(
sort: bool = True,
observed: bool = False,
dropna: bool = True,
**kwargs: Any,
) -> Vector:
return self._override_gdf_output(
self.ds.dissolve(
by=by, aggfunc=aggfunc, as_index=as_index, level=level, sort=sort, observed=observed, dropna=dropna
by=by,
aggfunc=aggfunc,
as_index=as_index,
level=level,
sort=sort,
observed=observed,
dropna=dropna,
**kwargs,
)
)

Expand Down
6 changes: 6 additions & 0 deletions tests/test_vector.py
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,12 @@ class TestGeoPandasMethods:
"merge",
"apply",
"astype",
"minimum_bounding_circle",
"minimum_bounding_radius",
"get_coordinates",
"hilbert_distance",
"sample_points",
"copy",
]
# Exceptions for IO/conversion that can be done directly from .ds
all_exceptions = exceptions_unimplemented
Expand Down
Loading