Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt changes to geouilts #519 and #501 #497

Closed
wants to merge 2 commits into from
Closed

Conversation

liuh886
Copy link
Contributor

@liuh886 liuh886 commented Mar 26, 2024

@rhugonnet
Copy link
Contributor

rhugonnet commented Mar 26, 2024

Hey @liuh886,
These changes (and many other changes due to the new GeoUtils releases) are already performed in #480. The PR has been awaiting review from @adehecq or @erikmannerfelt for the past weeks, and modifies a lot in the Coreg module including your gradient descending method.
Another re-structuration of Affine coregs will also come soon, as well as statistics and plotting functions, see #435

@rhugonnet
Copy link
Contributor

If you want to move forward on something, you can branch #480 (but you might have to solve some conflicts after its review is done in case you are modifying code in coreg/)

@liuh886 liuh886 closed this Mar 26, 2024
@liuh886
Copy link
Contributor Author

liuh886 commented Mar 26, 2024

Hey @liuh886,
These changes (and many other changes due to the new GeoUtils releases) are already performed in #480. The PR has been awaiting review from @adehecq or @erikmannerfelt for the past weeks, and modifies a lot in the Coreg module including your gradient descending method.
Another re-structuration of Affine coregs will also come soon, as well as statistics and plotting functions, see #435

Thanks, I should have checked the PR in review. Looking forward to those new functions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

area_or_point and get_mask - adapt changes to geouilts #519 and #501
2 participants