Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some suggestions to make nuth_kaab and deramping more consistent with ICP results #60

Closed
wants to merge 3 commits into from

Conversation

adehecq
Copy link
Member

@adehecq adehecq commented Mar 19, 2021

  • made changes to deramping so it works with masked Raster arrays
  • added a function to calculate a rotation, translation between two PCs. This was initially thought as a way to convert a "Ramp" into a transformation matrix (which seems to work!), but I'm curious to see how it performs on real point-clouds.
    @erikmannerfelt if you have a chance to take a look, I'm curious to hear what you think?

@rhugonnet
Copy link
Contributor

@erikmannerfelt @adehecq where are we on this, and in relation to #87? I'll dive into the details only if it is still needed

@erikmannerfelt
Copy link
Contributor

@rhugonnet the small corrections have been implemented in different PRs and I am working on the superinpose implementation with the Coreg subclass (see #94). Therefore, I will close this PR.

@adehecq adehecq deleted the transform branch May 17, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants