Removed all deprecated coreg functions. #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ramping which is used in GlacioHack#87
rhugonnet
approved these changes
Apr 20, 2021
There was a problem hiding this comment.
Perfect!
Closely related to this: what do you think about having the core structure of the coreg/biascorr functions, and their subfunctions, living in a structured fashion outside the Subclasses? I think this would be somewhat preferable as discussed in #71
Thanks! Perhaps we can discuss this in video at some point? I get your point, and see both pros and cons with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the old coreg functions (marked with
DeprecationWarnings) have been implemented asCoregsubclasses. They are therefore completely redundant, and we can remove them. The only function with aDeprecationWarningthat I have not removed is thederamping()function that found a use in #87.