Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scene: variable in message various bug (deleted when text is removed after the variable and list hides in case of type error). #1207

Closed
LM1LC3N7 opened this issue May 31, 2021 · 1 comment
Closed

Scene: variable in message various bug (deleted when text is removed after the variable and list hides in case of type error). #1207

LM1LC3N7 opened this issue May 31, 2021 · 1 comment

Comments

@LM1LC3N7
Copy link
Contributor

Describe the bug

I found 2 bugs:

  1. (video from start to 15sec) When I try to remove text or spaces after a variable, the variable will disappear itself. And text will not be able to be typed. On the video I am try to type something after the variable was deleted and nothing appears.
  2. (video from 18 sec to the end) When I write the variable name, if I make mistype a letter, I am forced to deleted the entire variable name until the {{ character. On a smartphone, it is really a pain to find the correct variable name if openweather API for example (very long JSON object).

To Reproduce

Steps to reproduce the behavior:

  1. Create a scene and get any value from an API or a device. I used the openweather API : https://api.openweathermap.org/data/2.5/onecall?lat=50&lon=5&lang=fr&exclude=minutely,hourly&appid=TOKEN
  2. Try to create a message from the scene with the weather description and mistype one letter in the variable name
  3. See, your are forced to delete the whole variable name and write it again

Expected behavior

The variable selector dropdown could appears again when the error is removed. For example, for a variable data.daily.0.wheater.0.description, if I type data.dailyy, removing the last y should make the dropdown menu appear again.

Screenshots

Video-2021-05-31-112050.mov

Your Gladys installation

  • Raspberry Pi 4B
  • OS: Windows 10
  • Browser: Firefox Nightly
@LM1LC3N7 LM1LC3N7 changed the title Scene: variable in message various bug (deleted when text is removed after the variable and list hides in cas of type error). Scene: variable in message various bug (deleted when text is removed after the variable and list hides in case of type error). May 31, 2021
Pierre-Gilles added a commit that referenced this issue Jul 2, 2021
@Pierre-Gilles
Fix #1207: In send message action in scene, going backspace should no…
6d4c5d4 
…t delete variable in Firefox
@Pierre-Gilles
Copy link
Contributor

Hey! I just investigated on this!

Both issues are linked to the lib we use for this: @yaireo/tagify

VonOx added a commit to VonOx/Gladys that referenced this issue Aug 22, 2021
@pull @VonOx
@Pierre-Gilles @cicoub13 @atrovato
[pull] master from GladysAssistant:master (#105)
a3bfee8 
* Fit map only on users (GladysAssistant#1223)

* Fix GladysAssistant#1197: Fix Websocket bug when accessToken is expired (GladysAssistant#1227)

* Fix bugs in scene, dashboard & settings (GladysAssistant#1228)

* Fix GladysAssistant#1225: Remove max height on user presence box

* Fix GladysAssistant#1207: In send message action in scene, going backspace should not delete variable in Firefox

* Fix GladysAssistant#1222: Make it possible to enter negative value in scene triggers

* Fix GladysAssistant#1106: Make it possible to use decimal numbers in scene

* Fix GladysAssistant#1055: Fix validation error message in house settings

* Fix GladysAssistant#1220: Add IKEA LED1836G9 (GladysAssistant#1224)

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>

* fix(zigbee2mqtt): Add Philips 9290022166 (GladysAssistant#1219)

Fix GladysAssistant#1209

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>

* 4.4.1

* Zigbee2mqtt: Add light color feature (GladysAssistant#1203)

* feat(zigbee2mqtt): Add color feature to devices

* feat(zigbee2mqtt): Add light color feature

Close GladysAssistant#1156

* feat(utils): Add XY color conversion to Int

https://gist.github.com/popcorn245/30afa0f98eea1c2fd34d

* feat(zigbee2mqtt): Fix PR feedbacks

* feat(core): Add Light Temperature Box Row

* fix(zigbee2mqtt): Fix Light Temperature min max values

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>

* Generate CHANGELOG

* Be able to disable a scene (GladysAssistant#1229)

* Add scene.active in DB

* Add active switch to scene list

* Add a way to update active in edit scene

* Rollback toggle if request fails

* Only checkTrigger if the scene is active or not

* Fix tests

* Add active attribute to demo file

* Add Cypress tests

* Multiple dashboard feature (GladysAssistant#1230)

* In user presence dashboard box, it's possible to select the users displayed (GladysAssistant#1238)

* In user presence dashboard box, it's possible to select the users displayed

* Add Cypress test on user presence box

* Edit empty state message

* Add device.setValue action in scene (GladysAssistant#1239)

* Configure Webpack stats file to calculate bundle evolution (GladysAssistant#1240)

* Fix bug when light color has no initial state and is displayed black (GladysAssistant#1235)

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>

* Stop using vis-network library in Z-Wave network tab to reduce bundle size (GladysAssistant#1241)

* Upgrade preact-cli to major version 3 (GladysAssistant#1242)

* Move config file to src folder

* Migrating to preact-cli 3

* sw-esm.js is not cached as well

* Use optimized version of tabler

* Add a service worker to unregister the old one

* Fix bug in edithouse component

* Fix tests & upgrade react-select

* Use actions/cache@v2 in Github Actions to better cache npm install

* Add ios splash screen PWA

* Add apple-mobile-web-app-status-bar-style

* copy old sw.js after building

* Dynamically import demo.json file save size

* Fix dashboard responsive (GladysAssistant#1243)

* Bluetooth check state before scan + stop presence scanner (GladysAssistant#1194)

* Bluettoth stop presence scanner

* Bluetooth check state before scan

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>

* Zigbee2mqtt: Add TuYa TS0601_air_quality_sensor and CO2 feature (GladysAssistant#1247)

* feat(zigbee2mqtt): Add CO2 feature management

* feat(zigbee2mqtt): Add TuYa TS0601_air_quality_sensor

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>

Co-authored-by: Vincent KULAK <vkulak62@gmail.com>
Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
Co-authored-by: Cyril Beslay <cicoub13@users.noreply.github.com>
Co-authored-by: Alexandre Trovato <1839717+atrovato@users.noreply.github.com>
Jean-PhilippeD pushed a commit to Jean-PhilippeD/Gladys that referenced this issue Oct 13, 2021
@Pierre-Gilles
Fix bugs in scene, dashboard & settings (GladysAssistant#1228)
4fbd76b 
* Fix GladysAssistant#1225: Remove max height on user presence box

* Fix GladysAssistant#1207: In send message action in scene, going backspace should not delete variable in Firefox

* Fix GladysAssistant#1222: Make it possible to enter negative value in scene triggers

* Fix GladysAssistant#1106: Make it possible to use decimal numbers in scene

* Fix GladysAssistant#1055: Fix validation error message in house settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Pierre-Gilles @LM1LC3N7