Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Gladys 4 in French #634

Closed
Pierre-Gilles opened this issue Jan 2, 2020 · 10 comments
Closed

Translate Gladys 4 in French #634

Pierre-Gilles opened this issue Jan 2, 2020 · 10 comments

Comments

@Pierre-Gilles
Copy link
Contributor

No description provided.

@Pierre-Gilles Pierre-Gilles added this to the Gladys 4 RC milestone Jan 2, 2020
@atrovato
Copy link
Contributor

atrovato commented Jan 3, 2020

Hi,
we may use compare-json to check if translate files are similar.

@atrovato
Copy link
Contributor

atrovato commented Jan 3, 2020

I just check for more plugin, I found eslint-plugin-preact-i18n which looks fine.
I propose a PR #644 to check this. But for now, there is around 150 i18n errors.

@Pierre-Gilles
Copy link
Contributor Author

Really nice! Thanks for finding this! We will merge this when translating in french.

@Terdious
Copy link
Contributor

Hi,
@atrovato, I just installed your fork for the resumption of the texts which were in hard. I'm starting to look, so I could come back here to report what I find. I also intended to put my translation file in fr there (you will just have to replace the file in to test it. Is that okay with you, do you want me to modify the texts by remaining hard or do I only give you the links?
The first :

I continue this weekend.
Looking forward

@atrovato
Copy link
Contributor

@Terdious it fine for me, send me the 'fr' file, I will test it.
Thank for the remaining hard coded texts, I will check another time :)

@atrovato
Copy link
Contributor

Ok, I check again for all hard coded texts (added --ext .jsx to front eslint), and fixed around 150 errors. Now en.json translation file should be complete.

@Terdious
Copy link
Contributor

Terdious commented Mar 1, 2020

@atrovato
Copy link
Contributor

atrovato commented Mar 1, 2020

Hi @Terdious , please find the result of FR analysis, missing keys

cr_trad_fr.txt

@Terdious
Copy link
Contributor

Terdious commented Mar 1, 2020

@atrovato
Sorry, I was delayed !!
Attached the new file, on should not be too bad. I also put you on the Galdys community screenshots of the texts that I find in English.
fr.txt
en.txt

@Pierre-Gilles
Copy link
Contributor Author

Pierre-Gilles commented Mar 2, 2020

Is PR #644 ready for merge?

Thanks for the great work !! :)

NickDub-old pushed a commit to NickDub/Gladys that referenced this issue Aug 7, 2020
…tant#771)

* i18n checker

* i18n: replace hard coded by keys

* i18n: add FR translations

* i18n: integration comparator

* i18n: update fr translation

* i18n: localize dates

* i18n: localize scenes

* i18n: clean not used messages

* i18n: dashboard select room

* i18n: fix merge conflicts

* i18n: remove backend files

* i18n: fix merge misses

* i18n: merge CalDAV integration

* i18n: merge new gateway page

* i18n: merge G.P backup

* Make app work in french too

* Fix some translations in FR

* Add default language from browser at signup

* Multiple translation fixes

* Add calendar translations

* Add messages in FR for the brain

* Improve translations

* Fix gateway translations

* Make integration page work in FR

* Fix french translations

* Fix translations

* Fix session translation

* Load language from local storage, then navigator if not in localstorage

Co-authored-by: atrovato <1839717+atrovato@users.noreply.github.com>
R6n0 pushed a commit to R6n0/Gladys that referenced this issue Dec 2, 2020
…tant#771)

* i18n checker

* i18n: replace hard coded by keys

* i18n: add FR translations

* i18n: integration comparator

* i18n: update fr translation

* i18n: localize dates

* i18n: localize scenes

* i18n: clean not used messages

* i18n: dashboard select room

* i18n: fix merge conflicts

* i18n: remove backend files

* i18n: fix merge misses

* i18n: merge CalDAV integration

* i18n: merge new gateway page

* i18n: merge G.P backup

* Make app work in french too

* Fix some translations in FR

* Add default language from browser at signup

* Multiple translation fixes

* Add calendar translations

* Add messages in FR for the brain

* Improve translations

* Fix gateway translations

* Make integration page work in FR

* Fix french translations

* Fix translations

* Fix session translation

* Load language from local storage, then navigator if not in localstorage

Co-authored-by: atrovato <1839717+atrovato@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants