Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add service management page #910

Closed
atrovato opened this issue Oct 24, 2020 · 3 comments
Closed

Add service management page #910

atrovato opened this issue Oct 24, 2020 · 3 comments
Assignees
@atrovato
Labels
effort:medium Tasks taking up to 1 day enhancement

Comments

@atrovato
Copy link
Contributor

Add a setting page to list and manage services: see status, able to stop / start services...
@atrovato atrovato self-assigned this Oct 25, 2020
@atrovato atrovato added effort:medium Tasks taking up to 1 day enhancement labels Oct 25, 2020
@atrovato
Copy link
Contributor Author

@Pierre-Gilles I'm working on the service page (to start / stop if if needed).
So I'll need to add a new "service.started" event over websocket.
But to do this, I'll need (2 possiblities):

  1. to handle the gladys.event.emit(EVENTS.ACTION.TRIGGERED, action); on service side, which implies to move following lines from scene.actions.js
  [ACTIONS.SERVICE.START]: async (self, action, scope) => self.stateManager.get('service', action.service).start(),
  [ACTIONS.SERVICE.STOP]: async (self, action, scope) => self.stateManager.get('service', action.service).stop(),
  1. or to call (no wait) directly serviceManager.start(service) from controller.

Any preference? (do you need more information?)

atrovato added a commit to atrovato/Gladys that referenced this issue Oct 30, 2020
@atrovato
Add service management pageFixes GladysAssistant#910
c582f7e
@atrovato
Copy link
Contributor Author

A simple preview

image

@Pierre-Gilles
Copy link
Contributor

This looks really great! Nice job!

atrovato added a commit to atrovato/Gladys that referenced this issue Nov 6, 2020
@atrovato
Add service management page - Fixes GladysAssistant#910
c0e1344
atrovato added a commit to atrovato/Gladys that referenced this issue Nov 6, 2020
@atrovato
Add service management page
37f4733 
Fixes GladysAssistant#910
atrovato added a commit to atrovato/Gladys that referenced this issue Nov 6, 2020
@atrovato
Add service management page Fixes GladysAssistant#910
92a541c
atrovato added a commit to atrovato/Gladys that referenced this issue Nov 6, 2020
@atrovato
Add service management page Fixes GladysAssistant#910
6e38f26
atrovato added a commit to atrovato/Gladys that referenced this issue Nov 6, 2020
@atrovato
Add service management page Fixes GladysAssistant#910
d405eb8
atrovato added a commit to atrovato/Gladys that referenced this issue Nov 7, 2020
@atrovato
Add service management pageFixes GladysAssistant#910
b965044
atrovato added a commit to atrovato/Gladys that referenced this issue Nov 20, 2020
@atrovato
Add service management pageFixes GladysAssistant#910
95f45b4
atrovato added a commit to atrovato/Gladys that referenced this issue Nov 21, 2020
@atrovato
Add service management page
18eba0b 
Fixes GladysAssistant#910
R6n0 pushed a commit to R6n0/Gladys that referenced this issue Dec 2, 2020
@Pierre-Gilles @atrovato
Add settings page to manage services (GladysAssistant#973)
0865548 
* Add service management page
Fixes GladysAssistant#910

* Fix translations

Co-authored-by: atrovato <1839717+atrovato@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atrovato atrovato

Labels
effort:medium Tasks taking up to 1 day enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atrovato @Pierre-Gilles