Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQTT: UI bug when connecting external broker #943

Closed
Pierre-Gilles opened this issue Nov 11, 2020 · 2 comments · Fixed by #1003
Closed

MQTT: UI bug when connecting external broker #943

Pierre-Gilles opened this issue Nov 11, 2020 · 2 comments · Fixed by #1003
Assignees
@atrovato
Labels
bug effort:low Tasks lower than 2 hours to develop to investigate

Comments

@Pierre-Gilles
Copy link
Contributor

If you go to the MQTT Integration, then configure an external broker, then save, then leave and come back, you see this as it's was not configured :

5SZkOKSU

Source :

Screenshot 2020-11-11 at 10 26 48
@atrovato atrovato self-assigned this Dec 5, 2020
@atrovato
Copy link
Contributor

atrovato commented Dec 5, 2020

I reproduce it easily. Should not be a lot of work.
On it.

@atrovato atrovato added bug effort:low Tasks lower than 2 hours to develop labels Dec 5, 2020
@atrovato
Copy link
Contributor

atrovato commented Dec 5, 2020

Ok, problème is that we store in a variable named useEmbeddedBroker a boolean, which is transformed to int and to string.
So we store useEmbeddedBroker = false but we retrieve useEmbeddedBroker = "0".

So check should be on string value useEmbeddedBroker === '1' to check if embedded broker is used.

atrovato added a commit to atrovato/Gladys that referenced this issue Dec 5, 2020
@atrovato
MQTT: UI bug when connecting external broker
c1897ce 
Fixes GladysAssistant#943
@atrovato atrovato mentioned this issue Dec 5, 2020
Merged
Pierre-Gilles added a commit that referenced this issue Dec 7, 2020
@atrovato @Pierre-Gilles
Fixes #943: MQTT, fix UI bug when connecting external broker (#1003)
3f2391d 
Fixes #943

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
atrovato added a commit to atrovato/Gladys that referenced this issue Feb 21, 2021
@atrovato @Pierre-Gilles
Fixes GladysAssistant#943: MQTT, fix UI bug when connecting external …
771f127 
…broker (GladysAssistant#1003)

Fixes GladysAssistant#943

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
This was referenced Apr 7, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atrovato atrovato

Labels
bug effort:low Tasks lower than 2 hours to develop to investigate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MQTT: UI bug when connecting external broker atrovato/Gladys
2 participants
@atrovato @Pierre-Gilles