Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk space rounded #1004

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Conversation

atrovato
Copy link
Contributor

@atrovato atrovato commented Dec 5, 2020

Fixes #989
Using Math.ceil instead of rounded, to me I prefer to 26% when 25.3% is real.

@codecov
Copy link

codecov bot commented Dec 5, 2020

Codecov Report

Merging #1004 (3c59b4b) into master (4709dd3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1004   +/-   ##
=======================================
  Coverage   94.65%   94.65%           
=======================================
  Files         494      494           
  Lines        6552     6552           
=======================================
  Hits         6202     6202           
  Misses        350      350           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4709dd3...3c59b4b. Read the comment docs.

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@Pierre-Gilles Pierre-Gilles merged commit 752d3b2 into GladysAssistant:master Dec 7, 2020
@atrovato atrovato deleted the atrovato/issue989 branch November 28, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants