[MQTT] Generate random client ID #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1034 +/- ##
=======================================
Coverage 94.97% 94.97%
=======================================
Files 524 524
Lines 6944 6944
=======================================
Hits 6595 6595
Misses 349 349
Continue to review full report at Codecov.
|
Pierre-Gilles
approved these changes
Jan 8, 2021
atrovato
pushed a commit
to atrovato/Gladys
that referenced
this pull request
Feb 21, 2021
* ✨ mqtt clientId random suffix * 🐛 Revert logging for fixing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
- [ ] If your changes affects code, did your write the tests?npm teston both front/server)npm run eslinton both front/server)npm run prettieron both front/server)- [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translationson front)- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.- [ ] Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Fix #1033