Inject scene variables in other boxes

[Pierre-Gilles]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• If your changes affects code, did your write the tests?
• Are tests passing? (npm test on both front/server)
• Is the linter passing? (npm run eslint on both front/server)
• Did you run prettier? (npm run prettier on both front/server)
• If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
• If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
• Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

[codecov]

Codecov Report

Merging #1047 (a04d53d) into master (d6f521a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1047      +/-   ##
==========================================
+ Coverage   94.97%   94.99%   +0.01%     
==========================================
  Files         524      524              
  Lines        6944     6950       +6     
==========================================
+ Hits         6595     6602       +7     
+ Misses        349      348       -1     

Impacted Files	Coverage Δ
server/lib/scene/scene.actions.js	96.10% <100.00%> (+1.73%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6f521a...a04d53d. Read the comment docs.

[Pierre-Gilles]

Hi @cicoub13 @VonOx @atrovato, I would love a review from you on this PR!

This is how it looks like:

variable-injection.mp4

Is the shortcut straightforward? (having to type " {{ " to open the variable list ?) Should we use another trigger ? Like "#" ?

This feature will be extended to basically all input field in scenes, for exemple in the HTTP request it could be super useful to automatically inject a variable into a POST body :)

[cicoub13]

It's ok for me. Tested in multiple conditions 👍
On little glitch when I decided to change again the user

{{ is ok to inject variable.

[atrovato]

All these values can be computed once and stored in a const instead of cumputing them n times in the loop.

[Pierre-Gilles]

mm I don't follow you

We have:

• M rows (before this row)
  • Each rows has N boxes
    • Each box has L variables

We loop on each rows before this one, then on each box in each row, then on each variable in each box.

How could we do better?

[Pierre-Gilles]

@cicoub13 zIndex problem fixed! :) Thanks!