Fix eslint warning #1049
Fix eslint warning #1049
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1049 +/- ##
=======================================
Coverage 95.22% 95.22%
=======================================
Files 525 525
Lines 6968 6968
=======================================
Hits 6635 6635
Misses 333 333 Continue to review full report at Codecov.
|
For |
|
@cicoub13 thank you for feedback. Node.jsx => is the output used to open Github Issue ? Or this is ok to replace by: const displayRawNode = node => () => {}; |
| const displayRawNode = node => () => { | ||
| console.log(node); | ||
| }; | ||
| const displayRawNode = node => () => {}; |
There was a problem hiding this comment.
You can remove this declaration and line 135 onClick={displayRawNode(props.node)}
There was a problem hiding this comment.
Why ? This was done on purpose so that the user can see his full raw node in the console to help us debug!
Opening the full raw Z-Wave node in GitHub doesn't work because it's too big to fit it an URL
There was a problem hiding this comment.
OK sorry. I thought the URL build was already containing the needed data.
In this case, @VonOx you must revert to keep the console.log and add this line above
// eslint-disable-next-line no-console
There was a problem hiding this comment.
No worries! I know it's really not ideal, we need to find another solution after that
// eslint-disable-next-line no-console
* Fix a lot of eslint warning * Fix Session and Node files * Ignore eslint no-console in Node.jsx // eslint-disable-next-line no-console * WeatherBox => weatherIcon Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
3 remaining warning, but I doesn't' know how to fix them: