Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: body can be empty in POST/PATCH request in actions #1072

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Feb 9, 2021

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #1072 (3ac6d71) into master (1d8005c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1072   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files         525      525           
  Lines        6968     6968           
=======================================
  Hits         6635     6635           
  Misses        333      333           
Impacted Files Coverage Δ
server/lib/scene/scene.actions.js 96.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d8005c...3ac6d71. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit c6170fe into master Feb 9, 2021
@Pierre-Gilles Pierre-Gilles deleted the fix-http-request-empty-body branch February 9, 2021 17:53
atrovato pushed a commit to atrovato/Gladys that referenced this pull request Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant