Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Bluetooth service fix #1093 #1097

Merged

Conversation

atrovato
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • [ ] Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Fix Bluetooth stop method to disable / unlink it.

@codecov
Copy link

codecov bot commented Mar 13, 2021

Codecov Report

Merging #1097 (835295b) into master (537be24) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1097   +/-   ##
=======================================
  Coverage   95.55%   95.56%           
=======================================
  Files         531      531           
  Lines        7112     7123   +11     
=======================================
+ Hits         6796     6807   +11     
  Misses        316      316           
Impacted Files Coverage Δ
...ices/bluetooth/lib/commands/bluetooth.getStatus.js 100.00% <100.00%> (ø)
.../services/bluetooth/lib/commands/bluetooth.scan.js 91.89% <100.00%> (ø)
.../services/bluetooth/lib/commands/bluetooth.stop.js 100.00% <100.00%> (ø)
server/services/bluetooth/lib/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 537be24...835295b. Read the comment docs.

cicoub13
cicoub13 previously approved these changes Mar 13, 2021
Copy link
Contributor

@cicoub13 cicoub13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me 👍

In server/services/bluetooth/lib/commands/bluetooth.stop.js, I prefer to use null rather than undefined, but I think it's more a preference and not a rule in Gladys (eslint allows it).

@atrovato atrovato added the bug label Mar 13, 2021
@Pierre-Gilles Pierre-Gilles merged commit 0ae38b9 into GladysAssistant:master Mar 18, 2021
Jean-PhilippeD pushed a commit to Jean-PhilippeD/Gladys that referenced this pull request Oct 13, 2021
Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
@atrovato atrovato deleted the fix-#1093-stop-ble-service branch November 28, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants