Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@callemand: Weather - Change UI from date to day and add sentence into chat #1105

Merged
merged 27 commits into from
Mar 26, 2021

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #1105 (bab2ea1) into master (dc25cf7) will increase coverage by 0.21%.
The diff coverage is 97.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1105      +/-   ##
==========================================
+ Coverage   95.59%   95.80%   +0.21%     
==========================================
  Files         532      533       +1     
  Lines        7189     7220      +31     
==========================================
+ Hits         6872     6917      +45     
+ Misses        317      303      -14     
Impacted Files Coverage Δ
server/lib/weather/weather.command.js 88.88% <96.55%> (+74.60%) ⬆️
server/lib/brain/brain.getReply.js 100.00% <100.00%> (ø)
server/lib/brain/brain.train.js 100.00% <100.00%> (+4.16%) ⬆️
server/lib/brain/index.js 100.00% <100.00%> (ø)
server/lib/weather/index.js 100.00% <100.00%> (ø)
server/lib/weather/weather.error.js 100.00% <100.00%> (ø)
server/services/openweather/lib/formatResults.js 100.00% <100.00%> (ø)
server/utils/constants.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc25cf7...bab2ea1. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit 8f6bc72 into master Mar 26, 2021
@Pierre-Gilles Pierre-Gilles deleted the callemand-weather_module_ext12 branch March 26, 2021 02:55
Jean-PhilippeD pushed a commit to Jean-PhilippeD/Gladys that referenced this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants