Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean code #1122

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Clean code #1122

merged 2 commits into from
Apr 6, 2021

Conversation

atrovato
Copy link
Contributor

@atrovato atrovato commented Apr 5, 2021

I was looking some old code, and found an unused loop process.
Just remove it.

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #1122 (bd373fe) into master (015c620) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1122      +/-   ##
==========================================
- Coverage   96.26%   96.26%   -0.01%     
==========================================
  Files         636      636              
  Lines        8087     8082       -5     
==========================================
- Hits         7785     7780       -5     
  Misses        302      302              
Impacted Files Coverage Δ
...ces/tasmota/lib/mqtt/tasmota.mqtt.handleMessage.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 015c620...bd373fe. Read the comment docs.

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you on Tasmota code ;)

@Pierre-Gilles Pierre-Gilles merged commit 3629a00 into GladysAssistant:master Apr 6, 2021
Jean-PhilippeD pushed a commit to Jean-PhilippeD/Gladys that referenced this pull request Oct 13, 2021
Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
@atrovato atrovato deleted the clean-code branch March 21, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants