Choose action select now correctly searches labels

[rob-mccann]

Pull Request check-list

• If your changes affects code, did your write the tests?
  • cant seem to see any test coverage at the moment for this
• Are tests passing? (npm test on both front/server)
• Is the linter passing? (npm run eslint on both front/server)
• Did you run prettier? (npm run prettier on both front/server)
• If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
• If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
• Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

Description of change

The select box is currently filtering on value part of the option which causes some results to be missed when searching/filtering the list.

Fixes #1123
Fixes #1094

[codecov]

Codecov Report

Merging #1126 (0bb776e) into master (be8e6c5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1126   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files         636      636           
  Lines        8087     8087           
=======================================
  Hits         7785     7785           
  Misses        302      302           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be8e6c5...0bb776e. Read the comment docs.

[LM1LC3N7]

Thank you for your work 🙂

[atrovato]

Good job, but I had the same problem with the trigger selector, do we do this here or in another PR?

[rob-mccann]

My suggestion would be to merge this for now if it's ok (as this is the select that was raised a couple of times). I'll take a look at wrapping react-select and replacing all instances with that so we can just pass in translation keys to avoid this boilerplate each time.

[Pierre-Gilles]

Looks good to me! Amazing work 🙂