Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zigbee2mqtt): Fix all lights #1127

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

cicoub13
Copy link
Contributor

@cicoub13 cicoub13 commented Apr 6, 2021

After feedback from community

  • Fix models
  • Fix brightness feature (not read_only)

- Fix models
- Fix brightness feature (not read_only)
@VonOx
Copy link
Contributor

VonOx commented Apr 6, 2021

Oh good catch, that explain why slider is not available on dashboard.

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #1127 (bd79992) into master (b878e6b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1127   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files         638      638           
  Lines        8090     8090           
=======================================
  Hits         7788     7788           
  Misses        302      302           
Impacted Files Coverage Δ
server/services/zigbee2mqtt/model/AduroSmart.js 100.00% <ø> (ø)
server/services/zigbee2mqtt/model/Airam.js 100.00% <ø> (ø)
server/services/zigbee2mqtt/model/Belkin.js 100.00% <ø> (ø)
server/services/zigbee2mqtt/model/Calex.js 100.00% <ø> (ø)
...r/services/zigbee2mqtt/model/CommercialElectric.js 100.00% <ø> (ø)
...er/services/zigbee2mqtt/model/DresdenElektronik.js 100.00% <ø> (ø)
server/services/zigbee2mqtt/model/ELKO.js 100.00% <ø> (ø)
server/services/zigbee2mqtt/model/EcoSmart.js 100.00% <ø> (ø)
server/services/zigbee2mqtt/model/GE.js 100.00% <ø> (ø)
server/services/zigbee2mqtt/model/GMYSmartBulb.js 100.00% <ø> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b878e6b...bd79992. Read the comment docs.

@atrovato atrovato requested a review from Pierre-Gilles April 7, 2021 06:38
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the fixes :)

@Pierre-Gilles Pierre-Gilles merged commit 8f834fe into GladysAssistant:master Apr 7, 2021
@cicoub13 cicoub13 deleted the fix-zigbee-devices branch May 15, 2021 16:32
Jean-PhilippeD pushed a commit to Jean-PhilippeD/Gladys that referenced this pull request Oct 13, 2021
- Fix models
- Fix brightness feature (not read_only)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants