-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade preact-i18n to 2.3.1-preactx #1133
Conversation
7c8d676
to
682d13a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1133 +/- ##
=======================================
Coverage 96.27% 96.27%
=======================================
Files 639 639
Lines 8097 8097
=======================================
Hits 7795 7795
Misses 302 302 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point!!!
All 'context' usages look changed.
I need to test it locally new.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I tested on most screens. Couldn't test some integrations (Zigbee2mqtt), l'll merge this on master, build a docker dev tag and ask the community to make sure everything is working properly.
Thank you for your contribution! 👏
Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.json
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
preact-i18n uses the new Context API and has removed support for the legacy API.
I've added a sort of shim in for now into these functions to allow us to rewrite them to use the new API one by one.
Allows #1128 to be re-added.
Closes #1132