Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect attribute #1137

Merged

Conversation

atrovato
Copy link
Contributor

@atrovato atrovato commented Apr 9, 2021

Something weird in dashboard boxes.
Some use feature.last_value, some uses feature.lastValue...

Did I miss something?
Or this fix looks good?

(searched all lastValue occurrences and replace with last_value)

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #1137 (5ea4056) into master (ff0bfbb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1137   +/-   ##
=======================================
  Coverage   96.30%   96.30%           
=======================================
  Files         639      639           
  Lines        8141     8141           
=======================================
  Hits         7840     7840           
  Misses        301      301           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff0bfbb...5ea4056. Read the comment docs.

@atrovato atrovato mentioned this pull request Apr 9, 2021
@atrovato atrovato force-pushed the fix-dashbord-boxes-last-value branch from ec2c813 to 9c670b2 Compare April 20, 2021 16:27
@Pierre-Gilles
Copy link
Contributor

I'm quite surprised, it seems you're right but I can't understand why it's working right now... (or maybe it's not working!)

@VonOx I think you coded the MultiLevel no? any idea?

@Pierre-Gilles
Copy link
Contributor

Indeed, @VonOx you coded the Brightness box:

https://github.com/GladysAssistant/Gladys/pull/1082/files#diff-91ffef4861a07c96af49b03dbbba5c76e5f0d2826031cbd119642cec2eb5a3a3R13

Is it working or did you code it blindly?

@Pierre-Gilles
Copy link
Contributor

Pierre-Gilles commented Apr 22, 2021

From my test, it seems you're right @atrovato, it's broken right now.

@VonOx
Copy link
Contributor

VonOx commented Apr 22, 2021

Yeah it works, but weirdly right now.

Slider is always at 50% when I switch light on and when I slide the button sometimes it stuck.

I have implemented brightness based on multi level but tested with my own devices.

I can't explain the behavior... Sorry

@Pierre-Gilles
Copy link
Contributor

It works to control devices, but the slider is always at 50% (because lastValue doesn't exist). I investigated, it never worked.

but @atrovato, I don't think your PR solves the issue. I have a feeling the slider component never worked, even with the right variable. It needs a little bit of work to understand how to make the slider component work.

Thanks for finding this Alex!

@VonOx
Copy link
Contributor

VonOx commented Apr 22, 2021

Brightness on my lights physically change so this is weird.

@Pierre-Gilles
Copy link
Contributor

@VonOx nothing weird, the control works indeed, it's the display which is broken

@VonOx
Copy link
Contributor

VonOx commented Apr 22, 2021

@VonOx nothing weird, the control works indeed, it's the display which is broken

Ok did'nt understand, my bad.

@Pierre-Gilles
Copy link
Contributor

@atrovato My bad, your PR solves the issue!

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on my side! Thanks!

@Pierre-Gilles Pierre-Gilles merged commit 2d1af7c into GladysAssistant:master Apr 22, 2021
@atrovato
Copy link
Contributor Author

I just read all... quite funny :)

Jean-PhilippeD pushed a commit to Jean-PhilippeD/Gladys that referenced this pull request Oct 13, 2021
Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
@atrovato atrovato deleted the fix-dashbord-boxes-last-value branch November 28, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants