-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect attribute #1137
Fix incorrect attribute #1137
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1137 +/- ##
=======================================
Coverage 96.30% 96.30%
=======================================
Files 639 639
Lines 8141 8141
=======================================
Hits 7840 7840
Misses 301 301 Continue to review full report at Codecov.
|
ec2c813
to
9c670b2
Compare
I'm quite surprised, it seems you're right but I can't understand why it's working right now... (or maybe it's not working!) @VonOx I think you coded the MultiLevel no? any idea? |
Indeed, @VonOx you coded the Brightness box: Is it working or did you code it blindly? |
From my test, it seems you're right @atrovato, it's broken right now. |
Yeah it works, but weirdly right now. Slider is always at 50% when I switch light on and when I slide the button sometimes it stuck. I have implemented brightness based on multi level but tested with my own devices. I can't explain the behavior... Sorry |
It works to control devices, but the slider is always at 50% (because lastValue doesn't exist). I investigated, it never worked. but @atrovato, I don't think your PR solves the issue. I have a feeling the slider component never worked, even with the right variable. It needs a little bit of work to understand how to make the slider component work. Thanks for finding this Alex! |
Brightness on my lights physically change so this is weird. |
@VonOx nothing weird, the control works indeed, it's the display which is broken |
Ok did'nt understand, my bad. |
@atrovato My bad, your PR solves the issue! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works on my side! Thanks!
I just read all... quite funny :) |
Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
Something weird in dashboard boxes.
Some use
feature.last_value
, some usesfeature.lastValue
...Did I miss something?
Or this fix looks good?
(searched all
lastValue
occurrences and replace withlast_value
)