Add time condition in scenes

[Pierre-Gilles]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• If your changes affects code, did your write the tests?
• Are tests passing? (npm test on both front/server)
• Is the linter passing? (npm run eslint on both front/server)
• Did you run prettier? (npm run prettier on both front/server)
• If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
• If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
• Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add a new condition in scenes:

[codecov]

Codecov Report

Merging #1151 (889eabf) into master (8224fc1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1151      +/-   ##
==========================================
+ Coverage   96.27%   96.30%   +0.02%     
==========================================
  Files         639      639              
  Lines        8112     8141      +29     
==========================================
+ Hits         7810     7840      +30     
+ Misses        302      301       -1     

Impacted Files	Coverage Δ
server/models/scene.js	93.75% <ø> (ø)
server/utils/constants.js	100.00% <ø> (ø)
server/lib/scene/scene.actions.js	97.34% <100.00%> (+0.79%)	⬆️
server/lib/scene/scene.execute.js	100.00% <100.00%> (+8.33%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8224fc1...889eabf. Read the comment docs.

[atrovato]

On screen

The list is AM / PM format, but not the field, any way to fix it?
And blue "remove" cross on field is not really sexy.

For more, I tried it, but condition time is in GMT.
I setup a condition between 18:40 and 18h45, run at 18:40:47.

2021-04-20T18:40:47+0200 <debug> scene.actions.js:152 (Object.condition.check-time) Condition isAfterHour not verified. Now = Tue, 20 Apr 2021 16:40:47 GMT < afterDate = Tue, 20 Apr 2021 16:40:47 GMT
2021-04-20T18:40:47+0200 <error> scene.execute.js:20 () AbortScene [Error]: CONDITION_IS_AFTER_HOUR_NOT_VERIFIED

[Pierre-Gilles]

The list is AM / PM format, but not the field, any way to fix it?

Right I forgot to add the user locale :) Fixing it.

And blue "remove" cross on field is not really sexy.

I know it's terrible, I'll try to do something but it's the lib ^^

I setup a condition between 18:40 and 18h45, run at 18:40:47.

Edit: Found the bug, fixing it now. I did a wrong usage of the dayjs library.

[Pierre-Gilles]

We are lucky, the guy who build the react date picker lib just added the ability to customize the clear button 2 days ago! Nice!

[Pierre-Gilles]

So I put the cross in grey, it looks better. Still, if anyone is CSS master and want to make it even better i'm open :D