Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add house empty/not empty condition in scene #1212

Merged
merged 4 commits into from
Jun 11, 2021
Merged

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #1212 (87d2820) into master (fd9d31e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1212   +/-   ##
=======================================
  Coverage   96.48%   96.49%           
=======================================
  Files         648      650    +2     
  Lines        8284     8306   +22     
=======================================
+ Hits         7993     8015   +22     
  Misses        291      291           
Impacted Files Coverage Δ
server/utils/constants.js 100.00% <ø> (ø)
server/lib/house/house.getUsersAtHome.js 100.00% <100.00%> (ø)
server/lib/house/house.isEmpty.js 100.00% <100.00%> (ø)
server/lib/house/index.js 100.00% <100.00%> (ø)
server/lib/scene/scene.actions.js 97.56% <100.00%> (+0.12%) ⬆️
server/models/house.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd9d31e...87d2820. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit d651e45 into master Jun 11, 2021
@Pierre-Gilles Pierre-Gilles deleted the add-house-condition branch June 11, 2021 09:00
Jean-PhilippeD pushed a commit to Jean-PhilippeD/Gladys that referenced this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant