Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Philips Hue 929002241201 to Zigbee2mqtt integration #1259

Merged

Conversation

thibautmery
Copy link
Contributor

@thibautmery thibautmery commented Aug 6, 2021

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@thibautmery
Copy link
Contributor Author

Ajout d'un nouveau model d'ampoule (ampoule philips hue vintage couleur jaune)

Copy link
Contributor

@atrovato atrovato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy, clear!

@Pierre-Gilles Pierre-Gilles changed the title Ajout du model Add Philips Hue 929002241201 to Zigbee2mqtt integration Sep 2, 2021
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #1259 (25f3f5c) into master (eed5464) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1259   +/-   ##
=======================================
  Coverage   96.52%   96.52%           
=======================================
  Files         669      669           
  Lines        8595     8595           
=======================================
  Hits         8296     8296           
  Misses        299      299           
Impacted Files Coverage Δ
server/services/zigbee2mqtt/model/Philips.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed5464...25f3f5c. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit 8e69313 into GladysAssistant:master Sep 2, 2021
@relativeci
Copy link

relativeci bot commented Sep 2, 2021

Job #27: Bundle Size — 5.66MB (0%).

8e69313 vs eed5464

Changed metrics (1/8)
Metric Current Baseline
Cache Invalidation 0% 55.4%
Changed assets by type (0/7)

No changes


View Job #27 report on app.relative-ci.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants