Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1280: When switching dashboard, similar box should be refreshed #1283

Merged
merged 7 commits into from
Sep 10, 2021

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Sep 10, 2021

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@relativeci
Copy link

relativeci bot commented Sep 10, 2021

Job #53: Bundle Size — 5.67MB (+0.05%).

7f0471e vs af87134

Changed metrics (1/8)
Metric Current Baseline
Cache Invalidation 52.29% 0%
Changed assets by type (1/7)
            Current     Baseline
JS 3.77MB (+0.08%) 3.77MB

View Job #53 report on app.relative-ci.com

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #1283 (355cec9) into master (af87134) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1283   +/-   ##
=======================================
  Coverage   96.52%   96.52%           
=======================================
  Files         669      669           
  Lines        8595     8595           
=======================================
  Hits         8296     8296           
  Misses        299      299           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af87134...355cec9. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit 7f0471e into master Sep 10, 2021
@Pierre-Gilles Pierre-Gilles deleted the fix-dashboard-switch-bug branch September 10, 2021 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant