Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signal quality feature #1315

Merged
merged 4 commits into from
Oct 11, 2021
Merged

Signal quality feature #1315

merged 4 commits into from
Oct 11, 2021

Conversation

VonOx
Copy link
Contributor

@VonOx VonOx commented Oct 11, 2021

@codecov
Copy link

codecov bot commented Oct 11, 2021 •
edited
Loading

Codecov Report

Merging #1315 (ee07c3b) into master (73169b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1315   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files         669      669           
  Lines        8625     8625           
=======================================
  Hits         8328     8328           
  Misses        297      297
Impacted Files Coverage Δ
server/utils/constants.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73169b3...ee07c3b. Read the comment docs.

@VonOx VonOx requested a review from Pierre-Gilles October 11, 2021 08:07
@Pierre-Gilles Pierre-Gilles merged commit c14e042 into GladysAssistant:master Oct 11, 2021
@relativeci
Copy link

relativeci bot commented Oct 11, 2021

Job #105: Bundle Size — 5.68MB (~+0.01%).

c14e042 vs 73169b3

Changed metrics (2/8)
Metric Current Baseline
Initial JS 2.84MB(~+0.01%) 2.84MB
Cache Invalidation 49.81% 0%
Changed assets by type (1/7)
            Current     Baseline
JS 3.78MB (~+0.01%) 3.78MB

View Job #105 report on app.relative-ci.com

ngeissel pushed a commit to ngeissel/Gladys that referenced this pull request Oct 14, 2021
Revert "Add signal quality feature (GladysAssistant#1315)"
7ee55d6 
This reverts commit c14e042.
ngeissel pushed a commit to ngeissel/Gladys that referenced this pull request Oct 14, 2021
Revert "Add signal quality feature (GladysAssistant#1315)"
75b79ec 
This reverts commit c14e042.
@VonOx VonOx deleted the signal-unit branch October 15, 2021 12:36
@SibuStephen SibuStephen mentioned this pull request Jun 29, 2022
Open
@KikiFUNstyle KikiFUNstyle mentioned this pull request Jun 29, 2022
Open
@KikiFUNstyle KikiFUNstyle mentioned this pull request Jan 9, 2023
Open
@SibuStephen SibuStephen mentioned this pull request Jan 10, 2023
Open
This was referenced Nov 28, 2023
Open
Open
@SibuStephen SibuStephen mentioned this pull request Mar 22, 2024
Open
@SibuStephen SibuStephen mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Gilles Pierre-Gilles Pierre-Gilles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VonOx @Pierre-Gilles