Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device temperature feature #1327

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

VonOx
Copy link
Contributor

@VonOx VonOx commented Oct 15, 2021

Fix #1321

Adding device temperature feature

#1302 must map device_temperature to this feature
https://www.zigbee2mqtt.io/information/supported_devices.html#e=device_temperature

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #1327 (bbffc4e) into master (661f4f1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1327   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files         669      669           
  Lines        8626     8626           
=======================================
  Hits         8329     8329           
  Misses        297      297           
Impacted Files Coverage Δ
server/utils/constants.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 661f4f1...bbffc4e. Read the comment docs.

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES !! Thanks @VonOx ! :)

@Pierre-Gilles Pierre-Gilles merged commit 94acaac into GladysAssistant:master Oct 18, 2021
@Pierre-Gilles Pierre-Gilles mentioned this pull request Oct 18, 2021
6 tasks
@relativeci
Copy link

relativeci bot commented Oct 18, 2021

Job #119: Bundle Size — 5.68MB (+0.01%).

94acaac vs 661f4f1

Changed metrics (1/8)
Metric Current Baseline
Initial JS 2.84MB(+0.02%) 2.84MB
Changed assets by type (1/7)
            Current     Baseline
JS 3.78MB (+0.02%) 3.78MB

View Job #119 report on app.relative-ci.com

@VonOx VonOx deleted the issue/1321 branch October 25, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create device feature "internal temperature" to avoid confusing device temp with ambiant temp
2 participants