Zigbee2mqtt lqi

[atrovato]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• If your changes affects code, did your write the tests?
• Are tests passing? (npm test on both front/server)
• Is the linter passing? (npm run eslint on both front/server)
• Did you run prettier? (npm run prettier on both front/server)
• If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
• If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
• If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
• Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

[codecov]

Codecov Report

Base: 96.66% // Head: 96.65% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (2f6541c) compared to base (122d9c1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1343      +/-   ##
==========================================
- Coverage   96.66%   96.65%   -0.01%     
==========================================
  Files         630      630              
  Lines        9289     9293       +4     
==========================================
+ Hits         8979     8982       +3     
- Misses        310      311       +1     

Impacted Files	Coverage Δ
server/services/zigbee2mqtt/exposes/numericType.js	100.00% <100.00%> (ø)
...ervices/zigbee2mqtt/utils/features/buildFeature.js	100.00% <100.00%> (ø)
server/lib/scene/scene.addScene.js	92.59% <0.00%> (-1.86%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[atrovato]

I wait for dashboard display...

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[atrovato]

It can be insterresting to merge it wirh #1575

[VonOx]

I comment here cause not sure if #1546 is involved

{
          "name": "Signal strength",
          "selector": "zigbee2mqtt-cuisine-signal-integer-linkquality",
          "category": "signal",
          "type": "integer",
          "read_only": true,
          "unit": null,
          "min": 0,
          "max": 255,
          "last_value": 2,
          "last_value_changed": "2022-09-06T13:04:35.969Z"
}

[VonOx]

Not sure why my features was created at 255 max.

After manually set to 5 max it's ok in dashboard.

[atrovato]

@VonOx max with 255 was an old version.

[Pierre-Gilles]

Tests are failing on Z2M discover:

[atrovato]

@VonOx in fact, max=255 is provided by z2m device, I take it from the device if it is provided...
I will need to add a "override" option to force the defined mapping.

[VonOx]

OK that's explain the behavior.

Not sure if it's a good way to store a converted value. ( I know we have already discussed this on forum 😉)

[Pierre-Gilles]

@VonOx Can you retry on your side and confirm it's working fine? :)

[VonOx]

@VonOx Can you retry on your side and confirm it's working fine? :)

It is, can be merged.

[Pierre-Gilles]

Good for me, good work 👏

[relativeci]

Job #465: Bundle Size — 7.01MB (0%).

80ae2e4 vs d6f0b2a

Changed metrics (1/10)

Metric	Current	Baseline
Cache Invalidation	0%	46.23%

Changed assets by type (0/7)

No changes

---

View Job #465 report on app.relative-ci.com