Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MQTT] User must know if connected or not #1349

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

atrovato
Copy link
Contributor

@atrovato atrovato commented Nov 8, 2021

Fixes #1016

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • [ ] If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Display connection status on setup page.

image

@atrovato atrovato force-pushed the atrovato/issue1016 branch 2 times, most recently from bce304a to 85c1537 Compare November 12, 2021 16:07
@atrovato atrovato marked this pull request as ready for review November 12, 2021 16:09
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #1349 (fcea130) into master (b6ab1c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1349   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files         613      613           
  Lines        8735     8735           
=======================================
  Hits         8433     8433           
  Misses        302      302           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6ab1c0...fcea130. Read the comment docs.

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on my side!

@Pierre-Gilles Pierre-Gilles merged commit a5c95dc into GladysAssistant:master Nov 25, 2021
@relativeci
Copy link

relativeci bot commented Nov 25, 2021

Job #155: Bundle Size — 6.67MB (+0.01%).

a5c95dc vs b6ab1c0

Changed metrics (2/8)
Metric Current Baseline
Initial JS 2.86MB(+0.03%) 2.86MB
Cache Invalidation 42.72% 0%
Changed assets by type (1/7)
            Current     Baseline
JS 4.76MB (+0.02%) 4.76MB

View Job #155 report on app.relative-ci.com

@atrovato atrovato deleted the atrovato/issue1016 branch November 28, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MQTT] User must know if connected or not
2 participants