Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random tests #1353

Merged

Conversation

atrovato
Copy link
Contributor

Sometimes, device aggration tests fail due to current date.
This fix current date to same date (taken from merge date).

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #1353 (1fd03b1) into master (925994d) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1353      +/-   ##
==========================================
- Coverage   96.60%   96.54%   -0.07%     
==========================================
  Files         613      613              
  Lines        8729     8729              
==========================================
- Hits         8433     8427       -6     
- Misses        296      302       +6     
Impacted Files Coverage Δ
server/utils/childProcess.js 66.66% <0.00%> (-33.34%) ⬇️
server/utils/functionsWrapper.js 71.42% <0.00%> (-28.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 925994d...1fd03b1. Read the comment docs.

@atrovato atrovato force-pushed the fix-device-aggregation-tests branch from 5c5881a to f405cea Compare November 10, 2021 13:29
@atrovato atrovato mentioned this pull request Nov 10, 2021
@atrovato
Copy link
Contributor Author

This one is blocked by #1354

I'll add changes from the other PR to this one to unlock tests and build.

@atrovato atrovato force-pushed the fix-device-aggregation-tests branch from f405cea to 1fd03b1 Compare November 10, 2021 14:57
@atrovato atrovato requested a review from VonOx November 10, 2021 14:58
@Pierre-Gilles Pierre-Gilles merged commit ffde6e0 into GladysAssistant:master Nov 11, 2021
@relativeci
Copy link

relativeci bot commented Nov 11, 2021

Job #137: Bundle Size — 6.67MB (0%).

ffde6e0 vs 925994d

No changes


View Job #137 report on app.relative-ci.com

@atrovato atrovato deleted the fix-device-aggregation-tests branch November 28, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants