Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix demo mode #1355

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Fix demo mode #1355

merged 2 commits into from
Nov 11, 2021

Conversation

atrovato
Copy link
Contributor

@atrovato atrovato commented Nov 10, 2021

  • Fix some bad paths on demo mode
  • Delete confusing demo.json file
  • Add timer on DemoHttpClient to see loaders.

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #1355 (60046a6) into master (ffde6e0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1355   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files         613      613           
  Lines        8729     8729           
=======================================
  Hits         8427     8427           
  Misses        302      302           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffde6e0...60046a6. Read the comment docs.

@atrovato atrovato force-pushed the fix-demo-mode branch 2 times, most recently from c276f9b to 47c0fb0 Compare November 10, 2021 19:13
@Pierre-Gilles
Copy link
Contributor

Oh shit I forgot to delete the demo.json file, my bad!

Nice catch, I'm good for this!

@atrovato atrovato marked this pull request as ready for review November 11, 2021 06:26
front/src/utils/DemoHttpClient.js Outdated Show resolved Hide resolved
@Pierre-Gilles Pierre-Gilles merged commit c8d87e2 into GladysAssistant:master Nov 11, 2021
@relativeci
Copy link

relativeci bot commented Nov 11, 2021

Job #140: Bundle Size — 6.67MB (+0.07%).

c8d87e2 vs ffde6e0

Changed metrics (2/8)
Metric Current Baseline
Initial JS 2.87MB(+0.03%) 2.86MB
Cache Invalidation 46.68% 0%
Changed assets by type (1/7)
            Current     Baseline
JS 4.76MB (+0.09%) 4.76MB

View Job #140 report on app.relative-ci.com

@atrovato atrovato deleted the fix-demo-mode branch November 28, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants