Fix integration search/sort form #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1395 +/- ##
=======================================
Coverage 96.59% 96.59%
=======================================
Files 627 627
Lines 9162 9162
=======================================
Hits 8850 8850
Misses 312 312 Continue to review full report at Codecov.
|
atrovato
force-pushed
the
integration-sort
branch
from
aa6eb75 to
b694c65
Compare
atrovato
force-pushed
the
integration-sort
branch
from
b694c65 to
e4bfe73
Compare
atrovato
force-pushed
the
integration-sort
branch
from
e4bfe73 to
0ce13e4
Compare
atrovato
force-pushed
the
integration-sort
branch
from
0ce13e4 to
13625dc
Compare
atrovato
force-pushed
the
integration-sort
branch
from
13625dc to
95663df
Compare
VonOx
previously approved these changes
Apr 9, 2022
atrovato
force-pushed
the
integration-sort
branch
from
95663df to
a105a64
Compare
atrovato
force-pushed
the
integration-sort
branch
2 times, most recently
from
8ab9b8f to
140e086
Compare
atrovato
force-pushed
the
integration-sort
branch
from
140e086 to
c62ab62
Compare
Pierre-Gilles
approved these changes
Jun 10, 2022
Pierre-Gilles
added a commit
that referenced
this pull request
Jun 10, 2022
This reverts commit 498d501.
|
My bad, I tested too fast, it's broken for non-admin users
|
|
I'm reverting the PR in the meantime #1555 |
Job #341: Bundle Size — 6.74MB (+0.02%).Changed metrics (2/10)
|
Pierre-Gilles
added a commit
that referenced
this pull request
Jun 10, 2022
atrovato
added a commit
to atrovato/Gladys
that referenced
this pull request
Jun 11, 2022
Merged
atrovato
added a commit
to atrovato/Gladys
that referenced
this pull request
Jun 18, 2022
atrovato
added a commit
to atrovato/Gladys
that referenced
this pull request
Jun 18, 2022
atrovato
added a commit
to atrovato/Gladys
that referenced
this pull request
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
[ ] If your changes affects code, did your write the tests?npm teston both front/server)npm run eslinton both front/server)npm run prettieron both front/server)[ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translationson front)[ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.[ ] Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Rework on integration actions, and make order direction works.
This can be tested directly in demo mode, in comparison with live demo mode.