Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alexa integration with Gladys Plus #1396

Merged
merged 19 commits into from
May 20, 2022
Merged

Add Alexa integration with Gladys Plus #1396

merged 19 commits into from
May 20, 2022

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Dec 6, 2021

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #1396 (16308ca) into master (d45a7aa) will increase coverage by 0.01%.
The diff coverage is 97.54%.

@@            Coverage Diff             @@
##           master    #1396      +/-   ##
==========================================
+ Coverage   96.57%   96.59%   +0.01%     
==========================================
  Files         618      627       +9     
  Lines        8992     9155     +163     
==========================================
+ Hits         8684     8843     +159     
- Misses        308      312       +4     
Impacted Files Coverage Δ
server/utils/constants.js 100.00% <ø> (ø)
server/services/alexa/index.js 71.42% <71.42%> (ø)
...r/lib/gateway/gateway.forwardDeviceStateToAlexa.js 94.87% <94.87%> (ø)
server/lib/gateway/gateway.handleAlexaMessage.js 100.00% <100.00%> (ø)
server/lib/gateway/gateway.handleNewMessage.js 91.42% <100.00%> (+0.51%) ⬆️
server/lib/gateway/index.js 100.00% <100.00%> (ø)
server/services/alexa/lib/alexa.onDiscovery.js 100.00% <100.00%> (ø)
server/services/alexa/lib/alexa.onExecute.js 100.00% <100.00%> (ø)
server/services/alexa/lib/alexa.onReportState.js 100.00% <100.00%> (ø)
server/services/alexa/lib/deviceMappings.js 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d45a7aa...16308ca. Read the comment docs.

@stale
Copy link

stale bot commented Mar 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 11, 2022
@Pierre-Gilles Pierre-Gilles marked this pull request as ready for review May 20, 2022 08:59
@relativeci
Copy link

relativeci bot commented May 20, 2022

Job #306: Bundle Size — 6.74MB (+0.15%).

1feac09 vs d45a7aa

Changed metrics (4/10)
Metric Current Baseline
Initial JS 2.86MB(+0.34%) 2.86MB
Initial CSS 294.1KB(~+0.01%) 294.08KB
Cache Invalidation 46.56% 48.33%
Modules 1171(+0.26%) 1168
Changed assets by type (2/7)
            Current     Baseline
CSS 312.03KB (~+0.01%) 312.01KB
JS 4.85MB (+0.2%) 4.84MB

View Job #306 report on app.relative-ci.com

@Pierre-Gilles Pierre-Gilles merged commit 1feac09 into master May 20, 2022
@Pierre-Gilles Pierre-Gilles deleted the alexa-service branch May 20, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant