-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix get gladys container id call for Debian > 10 & Ubuntu > 20.04 #1459
Conversation
Job #228: Bundle Size — 6.73MB (0%).
|
Codecov Report
@@ Coverage Diff @@
## master #1459 +/- ##
=======================================
Coverage 96.57% 96.58%
=======================================
Files 615 616 +1
Lines 8844 8866 +22
=======================================
+ Hits 8541 8563 +22
Misses 303 303
Continue to review full report at Codecov.
|
@VonOx FYI I improved your PR :) |
Clean! I can test tomorrow on Ubuntu (cidfile & cgroupv1) and Buster for cgroup v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- ok with cidfile
- ok cgroupV1
- ok cgroupV2 Raspbian buster
Amazing! :) Next job is to use this function in the zigee2mqtt integration to fix the Unraid use case |
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!