Presence sensor datetime in future #1328

[atrovato]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• [ ] If your changes affects code, did your write the tests?
• Are tests passing? (npm test on both front/server)
• Is the linter passing? (npm run eslint on both front/server)
• Did you run prettier? (npm run prettier on both front/server)
• If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
• [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
• [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
• Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Disallow future time.
Presence sensor future added in demo dashboard.

Fixes #1328

[codecov]

Codecov Report

Merging #1466 (46cc1ed) into master (3b6fe44) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1466   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files         616      616           
  Lines        8898     8898           
=======================================
  Hits         8595     8595           
  Misses        303      303           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b6fe44...46cc1ed. Read the comment docs.

[Pierre-Gilles]

Thanks for your PR! :)

The bug happens on any type of sensors, (due to clock difference between the Pi / and the browser of the user), here this PR doesn't fix it for other sensors like motion sensor (impossible to have a motion in the future)

[atrovato]

@Pierre-Gilles
Are you sure you tested the right code?

In the following screenshots, you will see on respectivly:

1. on 2 lines
   1. 3 days ago
   2. 3 days in the future
2. on 5 lines
   1. 3 days ago
   2. 2 hours ago
   3. now
   4. 2 hours in the future
   5. 3 days in the future

[Pierre-Gilles]

Indeed, it works! I don't know what didn't work last time !

[relativeci]

Job #268: Bundle Size — 6.82MB (~+0.01%).

969d215 vs d9915d1

Changed metrics (2/10)

Metric	Current	Baseline
Cache Invalidation	63.35%	46.42%
Duplicate Code	0.47%(+2.17%)	0.46%

Changed assets by type (1/7)

	Current	Baseline
JS	4.91MB (+0.01%)	4.91MB

---

View Job #268 report on app.relative-ci.com