-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE] Add more units #1479
[CORE] Add more units #1479
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1479 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 617 617
Lines 8921 8921
=======================================
Hits 8616 8616
Misses 305 305
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR, thanks @VonOx !
There are some translations missing in the i18n files, so those attributes could be used in the UI (in the MQTT integration for example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pierre-Gilles deviceFeatureCategory is already filled 😕
@VonOx Weird, because I'm not able to use those devices in the MQTT integration. Is it working on your side ? |
I miss some mapping in front/server, it's now better |
@Pierre-Gilles Can you look again please ? |
Hello @VonOx,
|
Hi @Terdious
"time-sensor": {
"shortCategoryName": "Time sensor",
"decimal": "Time (decimal)",
"integer": "Time (integer)"
} Combined with unit of your choice {
"microseconds": "μs",
"milliseconds": "ms",
"seconds": "s",
"minutes": "min",
"hours": "h",
"days": "j",
"weeks": "sem",
"months": "m",
"years": "an."
}
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! It'll really help users :)
I have a few changes.
Don't hesitate to open Gladys when doing this, then going to the MQTT integration, and see how it's looking in the UI, it should be easily searchable and understandable.
@Terdious I don't think we want to add this in this PR. It looks like there is some work to think about on heating devices, and if we include this development in this PR, this PR will never go out now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ca me parait bien !
Job #276: Bundle Size — 6.83MB (+0.21%).Changed metrics (2/10)
|
Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
[ ] If your changes affects code, did your write the tests?npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)[ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.[ ] Did you add fake requests data for the demo mode (front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Just adding some units asked by community and needed for future integrations ( Z2M Lixee TIC 👀 )