Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make device state validation more robust #1480

Merged
merged 3 commits into from
Mar 25, 2022

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@Pierre-Gilles Pierre-Gilles requested a review from atrovato March 22, 2022 17:12
@relativeci
Copy link

relativeci bot commented Mar 22, 2022

Job #249: Bundle Size — 6.73MB (0%).

dc5a183 vs 58aeb37

Changed metrics (1/10)
Metric Current Baseline
Cache Invalidation 0% 60.15%
Changed assets by type (0/7)

No changes


View Job #249 report on app.relative-ci.com

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #1480 (4f99c05) into master (58aeb37) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1480   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files         616      616           
  Lines        8887     8887           
=======================================
  Hits         8584     8584           
  Misses        303      303           
Impacted Files Coverage Δ
server/models/device_feature.js 100.00% <ø> (ø)
server/models/device_feature_state.js 100.00% <ø> (ø)
server/models/device_feature_state_aggregate.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58aeb37...4f99c05. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit dc5a183 into master Mar 25, 2022
@Pierre-Gilles Pierre-Gilles deleted the prevent-service-from-inserting-nan-numbers branch March 25, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants