z2m reversed binary #1517
Merged
z2m reversed binary #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrovato
force-pushed
the
z2m-contact-sensor
branch
from
0f764bd to
98f01b7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1517 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 617 617
Lines 8935 8940 +5
=======================================
+ Hits 8630 8635 +5
Misses 305 305
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
PR seems good, can you build a Docker image to get some reviews on it, then post the image here: https://community.gladysassistant.com/t/message-derreur-zigbee2mqtt/6846/91?u=pierre-gilles
atrovato
force-pushed
the
z2m-contact-sensor
branch
from
98f01b7 to
a64d493
Compare
Pierre-Gilles
approved these changes
May 13, 2022
Job #284: Bundle Size — 6.83MB (0%).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm teston both front/server)npm run eslinton both front/server)npm run prettieron both front/server)[ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translationson front)[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.[ ] Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Reverse z2m contact values for opening_sensor
https://community.gladysassistant.com/t/message-derreur-zigbee2mqtt/6846/79?u=alextrovato
Gladys z2m mapping feature now declares a "reversed" attribute to reverse true/false values.