Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder forgot password #1518

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

callemand
Copy link
Contributor

@callemand callemand commented May 8, 2022

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)

Description of change

I have just move the forgot password below the connection button to use more easy the keyboard to connect
Screenshot 2022-05-08 at 15 18 43

@codecov
Copy link

codecov bot commented May 8, 2022

Codecov Report

Base: 97.25% // Head: 97.25% // No change to project coverage 👍

Coverage data is based on head (a0c84fb) compared to base (06d878e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1518   +/-   ##
=======================================
  Coverage   97.25%   97.25%           
=======================================
  Files         642      642           
  Lines        9671     9671           
=======================================
  Hits         9406     9406           
  Misses        265      265           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@callemand callemand requested a review from Pierre-Gilles May 10, 2022 15:16
@stale
Copy link

stale bot commented Jul 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 9, 2022
@stale stale bot closed this Jul 16, 2022
@VonOx
Copy link
Contributor

VonOx commented Sep 14, 2022

Not stale

@VonOx VonOx reopened this Sep 14, 2022
@VonOx VonOx added enhancement effort:low Tasks lower than 2 hours to develop and removed stale labels Sep 14, 2022
@stale
Copy link

stale bot commented Nov 14, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 14, 2022
@stale stale bot closed this Nov 21, 2022
@Pierre-Gilles Pierre-Gilles reopened this Dec 16, 2022
@stale stale bot removed the stale label Dec 16, 2022
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me!

@Pierre-Gilles Pierre-Gilles merged commit a4eb84f into GladysAssistant:master Dec 16, 2022
@relativeci
Copy link

relativeci bot commented Dec 16, 2022

Job #896: Bundle Size — 6.96MiB (~+0.01%).

a4eb84f(current) vs 06d878e master#893(baseline)

Metrics (1 change)
                 Current
Job #896
     Baseline
Job #893
Initial JS 3.01MiB 3.01MiB
Initial CSS 293.57KiB 293.57KiB
Cache Invalidation 43.23% 0%
Chunks 52 52
Assets 148 148
Modules 1238 1238
Duplicate Modules 2 2
Duplicate Code 0.03% 0.03%
Packages 106 106
Duplicate Packages 8 8
Total size by type (1 change)
                 Current
Job #896
     Baseline
Job #893
CSS 310.75KiB 310.75KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.64MiB 1.64MiB
JS 4.91MiB (~+0.01%) 4.91MiB
Media 0B 0B
Other 4.95KiB 4.95KiB

View job #896 reportView master branch activity

@callemand callemand deleted the move-forgot-password branch July 11, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:low Tasks lower than 2 hours to develop enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants