Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: Missing await keyword #1529

Merged
merged 1 commit into from
May 20, 2022
Merged

Bluetooth: Missing await keyword #1529

merged 1 commit into from
May 20, 2022

Conversation

rpochet
Copy link
Contributor

@rpochet rpochet commented May 19, 2022

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • [x ] Is the linter passing? (npm run eslint on both front/server)
  • [x ] Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Missing await keyword in bluetooth manager start

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #1529 (2d1757d) into master (d45a7aa) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1529   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         618      618           
  Lines        8992     8992           
=======================================
  Hits         8684     8684           
  Misses        308      308           
Impacted Files Coverage Δ
server/services/bluetooth/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d45a7aa...2d1757d. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit 769808b into GladysAssistant:master May 20, 2022
@relativeci
Copy link

relativeci bot commented May 20, 2022

Job #307: Bundle Size — 6.74MB (0%).

769808b vs 1feac09

Changed metrics (1/10)
Metric Current Baseline
Cache Invalidation 0% 46.56%
Changed assets by type (0/7)

No changes


View Job #307 report on app.relative-ci.com

@Pierre-Gilles
Copy link
Contributor

@all-contributors please add @rpochet for code

@allcontributors
Copy link
Contributor

@Pierre-Gilles

I've put up a pull request to add @rpochet! 🎉

@rpochet rpochet deleted the bug_bluetooth branch June 14, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants