Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Webcals synchronization #1537

Merged

Conversation

bertrandda
Copy link
Contributor

@bertrandda bertrandda commented May 20, 2022

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

Add synchronization for Webcals associate to CalDAV account.
Also add description in calendar.event model and use it in scenes.

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #1537 (f6f76d4) into master (d45a7aa) will increase coverage by 0.02%.
The diff coverage is 97.95%.

@@            Coverage Diff             @@
##           master    #1537      +/-   ##
==========================================
+ Coverage   96.57%   96.59%   +0.02%     
==========================================
  Files         618      628      +10     
  Lines        8992     9205     +213     
==========================================
+ Hits         8684     8892     +208     
- Misses        308      313       +5     
Impacted Files Coverage Δ
server/lib/scene/scene.actions.js 97.88% <ø> (ø)
server/lib/scene/scene.checkCalendarTriggers.js 100.00% <ø> (ø)
server/models/calendar.js 88.88% <ø> (ø)
server/models/calendar_event.js 100.00% <ø> (ø)
server/seeders/20190403081927-calendar.js 100.00% <ø> (ø)
server/seeders/20190403081933-calendar-event.js 100.00% <ø> (ø)
...es/caldav/lib/calendar/calendar.syncUserWebcals.js 96.77% <96.77%> (ø)
server/lib/calendar/calendar.get.js 100.00% <100.00%> (ø)
server/services/caldav/api/caldav.controller.js 100.00% <100.00%> (ø)
server/services/caldav/index.js 95.34% <100.00%> (+0.90%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d45a7aa...f6f76d4. Read the comment docs.

@bertrandda bertrandda changed the title [WIP] Add Webcals synchronization Add Webcals synchronization May 21, 2022
@stale
Copy link

stale bot commented Aug 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 1, 2022
@bertrandda bertrandda removed the stale label Aug 5, 2022
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, works on my side!

@Pierre-Gilles Pierre-Gilles merged commit c80a3b6 into GladysAssistant:master Sep 12, 2022
@relativeci
Copy link

relativeci bot commented Sep 12, 2022

Job #460: Bundle Size — 6.85MB (+0.01%).

c80a3b6 vs cfe8d89

Changed metrics (2/10)
Metric Current Baseline
Initial JS 2.89MB(+0.03%) 2.89MB
Cache Invalidation 41.99% 58.69%
Changed assets by type (1/7)
            Current     Baseline
JS 4.88MB (+0.02%) 4.88MB

View Job #460 report on app.relative-ci.com

@bertrandda bertrandda deleted the feat/event-desc-webcal branch December 2, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants