Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push docker images to GHCR #1542

Merged

Conversation

VonOx
Copy link
Contributor

@VonOx VonOx commented May 25, 2022

Updating CI to push image to Github Container Registry
Good bandwidth and no request limitation.

For those using watchtower with a lot of container its a good choice.

Tested here => https://github.com/VonOx/gh-test-ci/pkgs/container/gladys

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #1542 (08ca5f3) into master (cb444cc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1542   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files         627      627           
  Lines        9159     9159           
=======================================
  Hits         8847     8847           
  Misses        312      312           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb444cc...08ca5f3. Read the comment docs.

@atrovato
Copy link
Contributor

Does it mean that we have to declare a GITHUB_TOKEN or Github knows itself?

It looks really clean ;)

@VonOx
Copy link
Contributor Author

VonOx commented May 26, 2022

Token is available in CI, nothing to do.

@Pierre-Gilles
Copy link
Contributor

Very nice, good idea! Do you confirm that we still push to DockerHub, it's just a second destination?

@VonOx
Copy link
Contributor Author

VonOx commented May 30, 2022

Yes dockerhub stuff still here, just another destination.

@Pierre-Gilles Pierre-Gilles merged commit b6c5393 into GladysAssistant:master May 30, 2022
@relativeci
Copy link

relativeci bot commented May 30, 2022

Job #324: Bundle Size — 6.74MB (0%).

b6c5393 vs 2f0bb52

Changed metrics (1/10)
Metric Current Baseline
Cache Invalidation 0% 42.37%
Changed assets by type (0/7)

No changes


View Job #324 report on app.relative-ci.com

@VonOx VonOx deleted the github-container-registry branch May 31, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants