Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alexa: Fix brightness control for device with custom brightness range #1561

Merged
merged 2 commits into from
Jun 17, 2022

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@Pierre-Gilles Pierre-Gilles linked an issue Jun 17, 2022 that may be closed by this pull request
@relativeci
Copy link

relativeci bot commented Jun 17, 2022

Job #346: Bundle Size — 6.74MB (0%).

3e35553 vs 56c5f7d

Changed metrics (1/10)
Metric Current Baseline
Cache Invalidation 0% 46.78%
Changed assets by type (0/7)

No changes


View Job #346 report on app.relative-ci.com

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #1561 (7a4f102) into master (56c5f7d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1561   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files         628      628           
  Lines        9234     9234           
=======================================
  Hits         8922     8922           
  Misses        312      312           
Impacted Files Coverage Δ
...r/lib/gateway/gateway.forwardDeviceStateToAlexa.js 94.87% <ø> (ø)
server/services/alexa/lib/alexa.onReportState.js 100.00% <ø> (ø)
server/services/alexa/lib/alexa.onExecute.js 100.00% <100.00%> (ø)
server/services/alexa/lib/deviceMappings.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56c5f7d...7a4f102. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit 3e35553 into master Jun 17, 2022
@Pierre-Gilles Pierre-Gilles deleted the fix-brightness-alexa branch June 17, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alexa integration with z2m lights ( brightness feature )
1 participant